Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mod Request]: minetest_mapgen_config #155

Closed
dacmot opened this issue Feb 26, 2023 · 3 comments · Fixed by #156
Closed

[Mod Request]: minetest_mapgen_config #155

dacmot opened this issue Feb 26, 2023 · 3 comments · Fixed by #156
Assignees
Labels
new-mod-proposal Consider the mod can be applied to the game

Comments

@dacmot
Copy link
Collaborator

dacmot commented Feb 26, 2023

Request

This is the URL for the mod I would like to be added:

https://codeberg.org/Dacmot/minetest_mapgen_config

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    *
  2. When could this mod be a strain on the server when no players are using the mod?
    *
  3. When does this mod destroy player's work?
    *
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    *
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    *
  6. Is this mod survival friendly? What items that it provides that should be craftable/obtainable, but arent?
    *
  7. When does this mod feel like cheating?
    *
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
    • Yes
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    *
  10. Is the licence one that we can include in WhyNot? (Whynot is under the GPLv3 only. Be sure you know what you are talking about or cite your source)
  • Yes, Apache.

Other comments

Will leave the review to someone else ;)

@dacmot dacmot added the new-mod-proposal Consider the mod can be applied to the game label Feb 26, 2023
@dacmot dacmot self-assigned this Feb 26, 2023
@dacmot dacmot linked a pull request Feb 27, 2023 that will close this issue
@Lazerbeak12345
Copy link
Collaborator

Added licence detail. PR is pending, so some things might be better to wait on.

@Lazerbeak12345
Copy link
Collaborator

@dacmot would you like to do the honors and update ContentDB as well? 😉

@dacmot
Copy link
Collaborator Author

dacmot commented Oct 1, 2023

It should happen automatically. When we create a release on github it creates a label, and contentdb should make a new version. Usually happens overnight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-mod-proposal Consider the mod can be applied to the game
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants