Adds minetest game mapgen configuration parameters #156

dacmot · 2023-02-27T01:55:57Z

And a few other mapgen goodies. See #60 and the readme for more info.

Lazerbeak12345

Lgtm!

mods/mapgen/minetest_mapgen_config/biomes.lua

Lazerbeak12345 · 2023-02-27T02:29:46Z

mods/mapgen/minetest_mapgen_config/biomes.lua

+
+
+    -- Keep only the "interesting" biomes in floatlands
+    if (string.find("coniferous_forest deciduous_forest savanna rainforest taiga desert grassland", name)) then


Perhaps a blacklist would be better here than a whitelist. I'm sure there's third party biomes that would look good here.

Excellent point. I will change that.

Alternatively, a plan to have this list be a setting would work very well also. No need to get locked into one particular way of doing things just yet lol.

mods/mapgen/minetest_mapgen_config/decorations.lua

mods/mapgen/minetest_mapgen_config/minetest.conf

dacmot · 2023-02-27T02:41:08Z

Sorry. Pushed a bit too soon. Still a few issues to iron out...

Lazerbeak12345

Sorry, I forgot I had questions and concerns... I need to work on that.

dacmot · 2023-02-27T02:45:30Z

No worries!

Lazerbeak12345 · 2023-02-27T02:47:41Z

Sorry. Pushed a bit too soon. Still a few issues to iron out...

Absolutely fine!

dacmot · 2023-04-17T00:16:30Z

I've playtested it a fair bit, but it might need some trying from a different perspective. Let me know what you think.

Lazerbeak12345 · 2023-04-18T17:05:37Z

Playtest looks good. I didn't notice any significant change, aside from these:

I couldn't find the cloud-lands.
For whatever reason I found two dongeons made of mtg_plus:silver_sandstone_gold and mtg_plus:silver_sandstone_cobble. I'm pretty sure this was already a feature, but I've never seen it before.

dacmot · 2023-04-19T00:53:53Z

I realized I never explained everything this PR changes, and many of those changes are not immediately apparent on a quick playtest. So here's a list more or less complete summary:

Change default cloudlands settings in minetest.conf
- Altitude increased to 2000
- cloudlands_altitude = 2000
- I don't remember why the other cloudland settings... I feel like I took them out of the mod's settingtypes.txt but looking at it now, I didn't change them all from the defaults.
Modify default dirt and sand filler depth, so when you start digging you don't hit rock immediately
- mapgen_conf.filler_layer_thickness = 20
- mapgen_conf.ocean_floor_thickness = 5
- mapgen_conf.riverbed_thickness = 5
Add a nice mountain-top cold/snow effect above 80
- mapgen_conf.mountaintops_altitude = 80
- mapgen_conf.hills_to_mountain_vertical_blend = 30
Changed the minetest game ore depths, which seem to have changed for the worst (IMHO) recently. Iron can be found at 0, copper -16, tin -32, mese and gold at -64, and diamond at -256. This to me makes no sense because iron is better than copper or bronze, and the digging progression is almost instantly gratified to diamond, the best MTG material. Is this a minecraft thing? /rant
- mapgen_conf.tin_ground_layer1_ymax = -30
- mapgen_conf.copper_ground_layer1_ymax = -30
- mapgen_conf.iron_ground_layer1_ymax = -200
- mapgen_conf.gold_ground_layer1_ymax = -400
- mapgen_conf.mese_ground_layer1_ymax = -600
- mapgen_conf.mese_block_ground_layer1_ymax = -1000
- mapgen_conf.diamond_ground_layer1_ymax = -1000
Similarly adjusted the YellowCrystals depth to be more progressive and a bit deeper.
- yellow_crystals.ore1_ymax = -350
- yellow_crystals.ore2_ymax = -450
- yellow_crystals.ore3_ymax = -550
- yellow_crystals.ore4_ymax = -650
- @Lazerbeak12345 Because of this, should we remove the meseblocks?
Changed the dungeon materials based on biome to add more variety, and take advantage of having mtg_plus. See mods/mapgen/minetest_mapgen_config/biomes.lua:111 and below for more info. These can obviously be changed again. Not sure they should be parameterized though.

dacmot · 2023-04-19T00:58:31Z

P.S. my method for quick play test is to start a local game in creative mode, do /grant all singleplayer, and then fly fast everywhere (and through ground: dungeons are easy to spot by their blockish shape) or use /teleport to reach cloudlands. I also use amidst to see all the biomes so I can teleport to them faster instead of searching.

Let me know if you know a more efficient way ;)

Lazerbeak12345 · 2023-04-21T02:19:17Z

I'm actually liking it so far, now that I know what to look for.

I think the meseblocks are fine - if we move them to be essentially the lowest altitude (and highest - like in the cloud-lands perhaps) form of mese. I'm thinking the altatude ranges (with some overlap) should include all crystals, ore and meseblock, but each in a range relative to their density.

Also, I noticed there weren't any caves in the cloudlands, but that may have just been the seed I was on. I didn't look long.

Lazerbeak12345 · 2023-04-21T02:20:16Z

P.S. my method for quick play test is to start a local game in creative mode, do /grant all singleplayer, and then fly fast everywhere (and through ground: dungeons are easy to spot by their blockish shape) or use /teleport to reach cloudlands. I also use amidst to see all the biomes so I can teleport to them faster instead of searching.

Let me know if you know a more efficient way ;)

yeah that's the only way I've figured out. I know theres a mod that lets you teleport to different biomes and such. I use that sometimes if I'm testing biomes as well.

dacmot · 2023-04-22T15:15:26Z

I don't recall seeing caves or dungeons in cloud islands. It could make a neat effect sometimes, but I think most islands are too small.

Lazerbeak12345 · 2023-04-22T17:28:39Z

I don't recall seeing caves or dungeons in cloud islands. It could make a neat effect sometimes, but I think most islands are too small.

Right. I only point this out because I've seen them in world-gen without these changes before. Most are too small for sure, but really large ones aren't uncommon either.

dacmot · 2023-06-01T03:11:36Z

I did some play testing and I could not find any caverns or dungeons as are found at the world surface or underground. I did however find some secret spider nests with fossilized eggs inside the bigger islands. I tested in both our latest release (2023-03-16) and this branch. @Lazerbeak12345, would you be able to find an example and post a screenshot?

On a separate topic, but related to cloudlands: looking at the mod's code and documentation, it looks like it can use the vines from plantlife. Could be a nice (separate) addition.

Lazerbeak12345 · 2023-06-01T17:24:26Z

It doesn't seem to be very easy to find the larger islands, but here's one with a (very) small cave. (Tested on new world, default everything, v7 worldgen)

Are you also looking for examples of caves at the surface? I found many of them in my search for dungeons, but couldn't find any dungeons this time. (in an earlier world I had once, there were about 5 surface level in just one biome, but that's not using this branch)

plantlife

When I get time I plan on taking your earlier advice and adding any mod that qualifies one at a time. Much faster turnaround that way.

dacmot · 2023-06-02T01:07:50Z

I use amidst (forums) to find the larger islands.

Ah, well, look at that. I tend to use carpathian instead of v7. Did you use whynot, or just MTG? I'll git it another go with v7.

dacmot · 2023-06-02T02:12:31Z

Does this count? :D

I suspect it might be because of the deeper dirt layer. The bottom of the islands are mostly rocks, and they seem more likely to have odd grooves and craggs.

dacmot · 2023-06-02T02:26:19Z

I'm also having difficulty finding dungeons at the surface sometimes. In some places however they are very abundant like here:

Lazerbeak12345 · 2023-06-02T19:33:42Z

Ah, well, look at that. I tend to use carpathian instead of v7. Did you use whynot, or just MTG? I'll git it another go with v7.

I used WhyNot. On this branch.

dacmot · 2023-06-03T16:08:56Z

I've been testing with current whynot and plain MTG+cloudlands in v7 with otherwise default. I can't find much in the way of caverns. I also tried reducing the fill layer depth in my branch but other than the expected thinner dirt layer, the floating islands seem very similar to other branches. The closest to caves I get is when two islands overlap.

Lazerbeak12345

LTGM. I don't see any actual problems, but if there's something that this isn't doing something that you want it to, then I suppose we still have changes that need to be made.

dacmot · 2023-10-01T00:00:43Z

I'm not sure I understand your comment in contrast with the approval. Is it an OK, or more of a "whatever, don't care"?

It's been a while, so I re-read the thread and I'm not seeing any outstanding issues other than possibly* losing caverns in cloudlands.

*I didn't see significant differences

Lazerbeak12345 · 2023-10-01T14:04:18Z

Sorry for the confusion.

Like you I'm not sure if the cloudland caverns are broken. I'm assuming they aren't, and even if they are I'm not sure if it's that much of a difference.

It all looks good to me. The extra options these changes will give us and our users will be good.

dacmot · 2023-10-01T16:11:50Z

OK. Will merge then. Thanks!

dacmot added 6 commits February 26, 2023 18:34

Add minetest_mapgen_config submodule

7519c8d

Rsync cleanup for minetest_mapgen_config

384fec7

Update mod_sources.txt

dc7c4ea

Update mod_sources.txt

ce18a44

Correct the path for minetest_mapgen_config

abad1ff

Build minetest_mapgen_config into game

b4ff588

dacmot requested a review from Lazerbeak12345 February 27, 2023 01:55

dacmot self-assigned this Feb 27, 2023

Remove badly placed minetest_mapgen_config

24c64da

dacmot linked an issue Feb 27, 2023 that may be closed by this pull request

[Mod Request]: minetest_mapgen_config #155

Closed

Lazerbeak12345 approved these changes Feb 27, 2023

View reviewed changes

dacmot marked this pull request as draft February 27, 2023 02:40

Lazerbeak12345 self-requested a review February 27, 2023 02:43

Lazerbeak12345 requested changes Feb 27, 2023

View reviewed changes

dacmot added 12 commits March 19, 2023 21:59

Fix crash if decoration has no biome

23f2915

Add configuration values for mapgen

32649fe

Update yellow_crystal from upstream.

13358ec

Rsync cleanup for minetest_mapgen_config

750a980

Update mod_sources.txt

3a9ac16

Merge remote-tracking branch 'upstream/main'

bc4f4eb

Add yellow crystals configuration

75da160

Adjusting crystal generation depth

5d1085c

Update yellow_crystal from upstream.

8cec36a

Update minetest_mapgen_config from upstream.

4138db6

Update mod_sources.txt

1c5f124

Adjust ore depths

43a1c87

dacmot marked this pull request as ready for review April 17, 2023 00:15

Lazerbeak12345 self-requested a review April 18, 2023 02:26

Lazerbeak12345 approved these changes Sep 30, 2023

View reviewed changes

dacmot merged commit 59b0dd9 into minetest-whynot:main Oct 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds minetest game mapgen configuration parameters #156

Adds minetest game mapgen configuration parameters #156

dacmot commented Feb 27, 2023

Lazerbeak12345 left a comment

Lazerbeak12345 Feb 27, 2023

dacmot Feb 27, 2023

Lazerbeak12345 Mar 2, 2023

dacmot commented Feb 27, 2023

Lazerbeak12345 left a comment

dacmot commented Feb 27, 2023

Lazerbeak12345 commented Feb 27, 2023

dacmot commented Apr 17, 2023

Lazerbeak12345 commented Apr 18, 2023

dacmot commented Apr 19, 2023

dacmot commented Apr 19, 2023 •

edited

Loading

Lazerbeak12345 commented Apr 21, 2023

Lazerbeak12345 commented Apr 21, 2023

dacmot commented Apr 22, 2023

Lazerbeak12345 commented Apr 22, 2023

dacmot commented Jun 1, 2023 •

edited

Loading

Lazerbeak12345 commented Jun 1, 2023

dacmot commented Jun 2, 2023

dacmot commented Jun 2, 2023

dacmot commented Jun 2, 2023 •

edited

Loading

Lazerbeak12345 commented Jun 2, 2023

dacmot commented Jun 3, 2023

Lazerbeak12345 left a comment

dacmot commented Oct 1, 2023

Lazerbeak12345 commented Oct 1, 2023

dacmot commented Oct 1, 2023 •

edited

Loading



		-- Keep only the "interesting" biomes in floatlands
		if (string.find("coniferous_forest deciduous_forest savanna rainforest taiga desert grassland", name)) then

Adds minetest game mapgen configuration parameters #156

Adds minetest game mapgen configuration parameters #156

Conversation

dacmot commented Feb 27, 2023

Lazerbeak12345 left a comment

Choose a reason for hiding this comment

Lazerbeak12345 Feb 27, 2023

Choose a reason for hiding this comment

dacmot Feb 27, 2023

Choose a reason for hiding this comment

Lazerbeak12345 Mar 2, 2023

Choose a reason for hiding this comment

dacmot commented Feb 27, 2023

Lazerbeak12345 left a comment

Choose a reason for hiding this comment

dacmot commented Feb 27, 2023

Lazerbeak12345 commented Feb 27, 2023

dacmot commented Apr 17, 2023

Lazerbeak12345 commented Apr 18, 2023

dacmot commented Apr 19, 2023

dacmot commented Apr 19, 2023 • edited Loading

Lazerbeak12345 commented Apr 21, 2023

Lazerbeak12345 commented Apr 21, 2023

dacmot commented Apr 22, 2023

Lazerbeak12345 commented Apr 22, 2023

dacmot commented Jun 1, 2023 • edited Loading

Lazerbeak12345 commented Jun 1, 2023

dacmot commented Jun 2, 2023

dacmot commented Jun 2, 2023

dacmot commented Jun 2, 2023 • edited Loading

Lazerbeak12345 commented Jun 2, 2023

dacmot commented Jun 3, 2023

Lazerbeak12345 left a comment

Choose a reason for hiding this comment

dacmot commented Oct 1, 2023

Lazerbeak12345 commented Oct 1, 2023

dacmot commented Oct 1, 2023 • edited Loading

dacmot commented Apr 19, 2023 •

edited

Loading

dacmot commented Jun 1, 2023 •

edited

Loading

dacmot commented Jun 2, 2023 •

edited

Loading

dacmot commented Oct 1, 2023 •

edited

Loading