This repository has been archived by the owner on May 13, 2024. It is now read-only.
Drop lots of methods and other things marked as deprecated #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed old primitive types that do not work with modern OpenGL.
Removes deprecated function getNumber as well as makes all line terminators the proper CR LN combo.
Removes deprecated member functions of IMaterialRendererServices.
sfan5
approved these changes
Sep 5, 2023
These can removed too if you want, just make sure to send a PR to remove the usage in Minetest too. |
grorp
added a commit
to grorp/irrlicht
that referenced
this pull request
Sep 17, 2023
sfan5
pushed a commit
that referenced
this pull request
Sep 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed everything I could marked as deprecated in the IrrlichtMT code base that was not used by Minetest. The only things I could not remove were the position2d file (deprecated, but used all over internally in the Irrlicht code), and the EGDS_MESSAGE_BOX_WIDTH and EGDS_MESSAGE_BOX_HEIGHT enum values in the IGUISkin file, used by gui/guiSkin.cpp in the Minetest repo.