This repository has been archived by the owner on May 13, 2024. It is now read-only.
Harden TGA image loader #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: adding some unit tests before merging stuff like this may be a good idea. And that’s definitely easier than with meshes. |
|
There are the fixes upstream has committed: 811a9f3...2986235 |
|
I'd prefer to merge from upstream first (if possible) and add further corrections later if necessary. At least 74d3a99 is not addressed by this PR. EDIT: I would be willing to backport those changes in a separate PR in case this option is chosen. |
|
Obsoleted. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix all problems from #236, and some more.
Closes #236.