Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timeline 组件 #47
base: master
Are you sure you want to change the base?
timeline 组件 #47
Changes from 23 commits
0a8815f
7590e72
0ac0403
e8a187c
30e942c
d710669
51c8607
725bb11
ac387ac
9046d4b
ea1045e
a66fde1
5097cb7
2be1ade
a2d8d37
740e45b
3fa4442
31e1c0e
125a2bf
8f1bae8
0242c83
4076654
4d2f259
61a2054
4a5dbf3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isCurrent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isCurrent 作为 Timeline 组件到 Timeline.Item 组件的一个传参,表示当前时间轴哪个节点高亮。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我的意思是:你叫做ifCurrent,是不是isCurrent比较规范?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lineHeight为啥单独暴露出来,
如果要支持不同尺寸,应该是大中小的size(fontSize 搭配 lineHeight)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lineHeight 表示线条的高度, 可能命名和 line-height 重名了。不知道有没有其它名字推荐。比如当 lineHeight 为 0 时,相应的时间轴就’消失‘了。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lineHeight感觉不如lineStyle好,可以自定义宽度 高度 颜色啥的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
主要是歧义比较严重
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
key=index不推荐?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
因为这里没有数组首位增删的操作, 所以不会造成 index 作为 key 造成的 bug, 不过还可以用什么作为 key 呢, 除了随机数。