Added Cluster icon and iconsize

[tanure]

I added an implementation to be able to add icon for a Cluster

[AutomationD]

FYI, seems like it won't be merged as probably doesn't conform with standards.

Thanks to @tanure I was able to create an external option which works just fine:

def icon(node: object, label: str, size=30):
    """
    Function adds a Diagrams-compatible icon

    :param node: Diagrams object, like VPC or Docker
    :param label: Label text, like "subnet-a"
    :param size: Icon size in px.
    :returns: "Label prefixed with a specified icon"
    """
    # o = node.__new__(cls=None, label=label, size=size)

    class Node(node):
        def __init__(self):
            pass

    icon_path = Node()._load_icon()
    return '<<table border="0" width="100%"><tr><td fixedsize="true" width="' + str(size) + '" height="' + str(
        size) + '"><img src="' + icon_path + '" /></td><td>' + label + '</td></tr></table>>'

To be used like this:

    with Cluster(icon(VPC, "prod-vpc")):
        ...

[tanure]

I missed the conflict. I didn't see the notification about it. However, I'm really happy because @AutomationD created an alternative and improved code. Thanks a lot and it's good to learn with you!

[AutomationD]

I missed the conflict. I didn't see the notification about it. However, I'm really happy because @AutomationD created an alternative and improved code. Thanks a lot and it's good to learn with you!

You're too kind!

I don't think I've improved anything, it would be still great to do it without external functions. Maybe @mingrammer can give a hint what can be improved on the PR?

[AutomationD]

Also, seems like there is an issue with my code. I'm getting an actual node on the diagram in addition to the icon. I'll see if I can fix it.

[tanure]

This is really community! Let's contribute and learn. I'm going to test it as well!

Thanks a lot @AutomationD

[AutomationD]

@tanure OK, seems like overriding __init__ was good enough.
I've updated the original snippet.

[Anddd7]

Thanks for @tanure, I made some adjustment based on your changes. Use the type of Node instead of the Node instance, so no node generated actually. Overwrite the color of the clusters, it looks better now.

Anddd7#1
Anddd7#2

[JobaDiniz]

why isn't this merged yet?

[tiaz0128]

@filipeaaoliveira

Hi, I noticed this feature has been developed but hasn't been merged yet. I'm interested in contributing to this project and would like to understand.

1. What are the current blockers for this merge?
2. Is there anything I can help with to get this feature merged?

I'd be happy to assist with additional development or testing if needed.

[filipeaaoliveira]

Hello @tiaz0128

The project was stopped for a while.
We recently started to develop some things slowly and are trying to go over all the old PRs and issues, so time is really the only blocker here.

Thank you!

[tiaz0128]

@filipeaaoliveira

Thank you for bringing this project back to life. I'm a regular user and really appreciate your work on it.

I'd be happy to help with simple tasks like updating icons or keeping things up to date. Please let me know if there are any such tasks I can assist with.

If you create an issue for any task, I'll be happy to work on it.

[filipeaaoliveira]

Hello @tiaz0128

Thank you!
We are a small team that @mingrammer appointed. You can work on any open issue if you want and submit a PR and we can review it when we have the time.

[mingrammer]

Related PR: #438