Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve minhnh/rdf-utils#11 #12

Merged
merged 1 commit into from
Nov 17, 2024
Merged

resolve minhnh/rdf-utils#11 #12

merged 1 commit into from
Nov 17, 2024

Conversation

minhnh
Copy link
Owner

@minhnh minhnh commented Nov 17, 2024 •
edited
Loading

This implements the first of the two solutions described in #11. Regarding the 2nd, it's unclear to me at the moment how to trigger the class function in a subclasse's constructor of ModelBase.

  • add types arg to ModelBase.init, check whether graph or types is specified
  • move type query logic to get_node_types
  • update super classes and unit tests

@minhnh
resolve #11
83a3c44 
- add `types` arg to ModelBase.__init__, check whether `graph` or
  `types` is specified
- move type query logic to `get_node_types`
- update super classes and unit tests
@minhnh minhnh added the enhancement New feature or request label Nov 17, 2024
@minhnh minhnh self-assigned this Nov 17, 2024
@minhnh minhnh merged commit bf317c8 into main Nov 17, 2024
3 checks passed
@minhnh minhnh deleted the refactor/decouple-type-extract branch November 17, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@minhnh minhnh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@minhnh