fix: ignore non-spec fields update

Signed-off-by: minhthong582000 <[email protected]>

gitops/example/application.yaml

@@ -2,8 +2,17 @@
 kind: Application
 apiVersion: thongdepzai.cloud/v1alpha1
 metadata:
-  name: example-application
+  name: nginx-application
 spec:
   repository: https://github.com/minhthong582000/k8s-controller-pattern.git
   revision: main
   path: gitops/example/nginx
+---
+kind: Application
+apiVersion: thongdepzai.cloud/v1alpha1
+metadata:
+  name: ubuntu-application
+spec:
+  repository: https://github.com/minhthong582000/k8s-controller-pattern.git
+  revision: main
+  path: gitops/example/ubuntu

gitops/example/ubuntu/deployment.yaml

@@ -0,0 +1,25 @@
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+  name: ubuntu-deployment
+  labels:
+    app: ubuntu
+spec:
+  selector:
+    matchLabels:
+      app: ubuntu
+  replicas: 1
+  template:
+    metadata:
+      labels:
+        app: ubuntu
+    spec:
+      containers:
+        - name: ubuntu
+          image: ubuntu:22.04
+          resources:
+            requests:
+              cpu: 100m
+              memory: 512Mi
+            limits:
+              memory: 512Mi

gitops/internal/controller/controller.go

@@ -406,6 +406,11 @@ func (c *Controller) handleUdate(old, new interface{}) {
 		return
 	}
 
+	// If there are changes in fields other than spec, we don't need to reconcile
+	if !equality.Semantic.DeepEqual(oldApp.ObjectMeta, newApp.ObjectMeta) || !equality.Semantic.DeepEqual(oldApp.Status, newApp.Status) {
+		return
+	}
+
 	// Compare old and new spec
 	if equality.Semantic.DeepEqual(oldApp.Spec, newApp.Spec) {
 		log.Debugf("No changes in application spec: %s", newApp.Name)

gitops/utils/kube/kube.go

@@ -6,11 +6,11 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
-	"reflect"
 	"strings"
 	"sync"
 
 	log "github.com/sirupsen/logrus"
+	"k8s.io/apimachinery/pkg/api/equality"
 	apierr "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
@@ -232,7 +232,8 @@ func (k *k8s) DiffResources(current []*unstructured.Unstructured, new []*unstruc
 			continue
 		}
 
-		if !reflect.DeepEqual(c.Object["spec"], n.Object["spec"]) {
+		// TODO: handle kubernetes default values or else the comparison is useless
+		if !equality.Semantic.DeepEqual(c.Object["spec"], n.Object["spec"]) {
 			log.Debugf("Resource %s with name %s has changed", n.GetKind(), n.GetName())
 			isChanged = true
 		}
@@ -242,7 +243,7 @@ func (k *k8s) DiffResources(current []*unstructured.Unstructured, new []*unstruc
 	// Check if there are resources that need to be deleted
 	if len(hashTable) > 0 {
 		for _, c := range hashTable {
-			log.Debugf("Resource %s with name %s should be deleted", c.GetKind(), c.GetName())
+			log.Debugf("Resource %s with name %s not found, could be deleted or a child resource", c.GetKind(), c.GetName())
 		}
 		isChanged = true
 	}