Add sdl2-compat #1366
Closed
Add sdl2-compat #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See RHELPLAN-171489
yselkowitz
requested changes
Feb 7, 2025
There was a problem hiding this comment.
hi @wtay thanks for the PR. Please note that sdl2-compat Provides: SDL2 just like sdl12-compat Provides: SDL. Therefore, either this can just be left as is (and rely on the Provides), or the -compat packages should replace the original names.
Ok, then I think it's better to leave it as is for now. Eventually we want to remove the SDL2 package and only have sdl2-compat. When that happens, we should replace the SDL2 line with sdl2-compat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See RHELPLAN-171489