Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete KES functionality #3414

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

ramondeklein
Copy link
Collaborator

@ramondeklein ramondeklein commented Jul 24, 2024

This PR removes all API handlers for the obsolete MinIO KES functions that were removed already in minio/minio#19368. It's also not possible to import/delete keys anymore (other functionality wasn't available through the web interface).

Note that importing/deleting keys already didn't work anymore since minio/minio#19368 was merged. This PR also removes it from the console. Without this PR, the buttons are there but result in errors.

Fixes #3412.

@ramondeklein ramondeklein requested a review from reivaj05 July 24, 2024 19:04
@ramondeklein ramondeklein self-assigned this Jul 24, 2024
@ramondeklein ramondeklein removed the request for review from reivaj05 July 24, 2024 19:05
@ramondeklein ramondeklein force-pushed the remove-obsolete-kes-functions branch from c64a316 to 310f1bb Compare July 24, 2024 19:08
@ramondeklein ramondeklein requested review from prakashsvmx, reivaj05, bexsoft and aead and removed request for prakashsvmx and reivaj05 July 24, 2024 19:20
@ramondeklein ramondeklein marked this pull request as ready for review July 24, 2024 19:21
@ramondeklein ramondeklein requested a review from dvaldivia July 24, 2024 19:22
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cesnietor cesnietor merged commit 4d12a50 into minio:master Aug 2, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete some KES functionality
3 participants