Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Web App workflows #3423

Merged
merged 2 commits into from
Aug 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web-app/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@ default: build-static
build-static:
@echo "Building frontend static assets to 'build'"
@if [ -f "${NVM_DIR}/nvm.sh" ]; then \. "${NVM_DIR}/nvm.sh" && nvm install && nvm use; fi && \
NODE_OPTIONS=--openssl-legacy-provider yarn build
yarn build

build-static-istanbul-coverage:
@echo "Building frontend static assets to 'build'"
@if [ -f "${NVM_DIR}/nvm.sh" ]; then \. "${NVM_DIR}/nvm.sh" && nvm install && nvm use; fi && \
NODE_OPTIONS=--openssl-legacy-provider yarn buildistanbulcoverage
yarn buildistanbulcoverage

test-warnings:
./check-warnings.sh
Expand Down
2 changes: 1 addition & 1 deletion web-app/check-warnings-istanbul-coverage.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ die() {
try() { "$@" &> yarn.log || die "cannot $*"; }

rm -f yarn.log
try make build-static-istanbul-coverage
try yarn buildistanbulcoverage

if cat yarn.log | grep "Compiled with warnings"; then
echo "There are warnings in the code"
Expand Down
2 changes: 1 addition & 1 deletion web-app/check-warnings.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ die() {
try() { "$@" &> yarn.log || die "cannot $*"; }

rm -f yarn.log
try make build-static
try yarn build

if cat yarn.log | grep "Compiled with warnings"; then
echo "There are warnings in the code"
Expand Down
2 changes: 1 addition & 1 deletion web-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -93,5 +93,5 @@
"semver": "^7.5.2"
},
"main": "index.js",
"packageManager": "yarn@4.3.0"
"packageManager": "yarn@4.4.0"
}
4 changes: 2 additions & 2 deletions web-app/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -17244,11 +17244,11 @@ __metadata:

"typescript@patch:typescript@npm%3A^5.5.3#optional!builtin<compat/typescript>":
version: 5.5.3
resolution: "typescript@patch:typescript@npm%3A5.5.3#optional!builtin<compat/typescript>::version=5.5.3&hash=b45daf"
resolution: "typescript@patch:typescript@npm%3A5.5.3#optional!builtin<compat/typescript>::version=5.5.3&hash=379a07"
bin:
tsc: bin/tsc
tsserver: bin/tsserver
checksum: 10c0/5a437c416251334deeaf29897157032311f3f126547cfdc4b133768b606cb0e62bcee733bb97cf74c42fe7268801aea1392d8e40988cdef112e9546eba4c03c5
checksum: 10c0/911c7811d61f57f07df79c4a35f56a0f426a65426a020e5fcd792f66559f399017205f5f10255329ab5a3d8c2d1f1d19530aeceffda70758a521fae1d469432e
languageName: node
linkType: hard

Expand Down
Loading