Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] testcafe ui tests experiment with firefox in ci #3457

Closed
wants to merge 8 commits into from
Closed

[WIP] testcafe ui tests experiment with firefox in ci #3457

wants to merge 8 commits into from

Conversation

prakashsvmx
Copy link
Member

fix testcafe ui tests

@prakashsvmx prakashsvmx force-pushed the fix-ci-tests branch 3 times, most recently from 66013e5 to 7c487cf Compare October 24, 2024 07:09
@prakashsvmx prakashsvmx mentioned this pull request Oct 24, 2024
Merged
@prakashsvmx
Copy link
Member Author

prakashsvmx commented Oct 25, 2024 •
edited
Loading

@cesnietor - in CI i tried with firefox. seems the tests are passing.

so test failures in other PRs related to CI/testcafe/chrome specific.

Suggestion: We can add tests with firefox as well in CI to isolate any issues in future.

//cc @ramondeklein

@cesnietor
Copy link
Collaborator

cesnietor commented Oct 25, 2024 •
edited
Loading

Suggestion: We can add tests with firefox as well in CI to isolate any issues in future.

I remember we started doing just chrome cause long time before it was also just working on chrome haha.
@prakashsvmx is the issue in Chrome an actual issue? or just part of a bug in testcafe? like if you try to reproduce it?

I'm ok doing firefox temporary till the bug gets fixed but we need to add a comment there as a FIXME: once the bug is solved cause Chrome is still more common than Firefox.

@prakashsvmx
Copy link
Member Author

prakashsvmx commented Oct 28, 2024 •
edited
Loading

@cesnietor the issue is with testcafe and chrome version in CI.
( once testcafe fixes the issue in upstream we can upgrade the version in ci jobs)

@prakashsvmx prakashsvmx changed the title [WIP] fix testcafe ui tests [WIP] testcafe ui tests experiment with firefox in ci Oct 28, 2024
@prakashsvmx
Copy link
Member Author

Closing as now the tests are passing in CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prakashsvmx @cesnietor