Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve main SDK page #1047

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Improve main SDK page #1047

merged 3 commits into from
Oct 25, 2023

Conversation

feorlen
Copy link
Collaborator

@feorlen feorlen commented Oct 24, 2023 •
edited
Loading

Small cleanup of the main SDK index page.

[x] More clearly link to respective Quickstarts, API references, and GitHub repos.
[x] Reorder more-or-less by popularity.

Non-goals:
Validating the install steps provided (except replace go get with go install ...@version)

Staged:
http://192.241.195.202:9000/staging/main-sdk-page/linux/developers/minio-drivers.html

ravindk89
ravindk89 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit - for those where we have both reference and quickstart, we might as well link to both. especially since the reference is nested under the top-level sdk landing page/quickstart.

Otherwise LGTM.

source/developers/minio-drivers.rst Show resolved Hide resolved
source/developers/minio-drivers.rst Outdated Show resolved Hide resolved
djwfyi
djwfyi approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@djwfyi djwfyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go forth, apply Ravind's feedback, and merge

@feorlen feorlen merged commit 8b4e38d into main Oct 25, 2023
@feorlen feorlen deleted the main-sdk-page branch October 25, 2023 16:59
@feorlen
Copy link
Collaborator Author

feorlen commented Oct 25, 2023

Note: further improvements via #752

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djwfyi djwfyi djwfyi approved these changes

@ravindk89 ravindk89 ravindk89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feorlen @ravindk89 @djwfyi