Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs automation: fix |java-jar-url| replacement #1049

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Conversation

feorlen
Copy link
Collaborator

@feorlen feorlen commented Oct 26, 2023

The URL for the Java SDK JAR is a static string + the SDK version number. Use the existing java-sdk-version value to construct the correct URL.

C++ doesn't have any releases, so there's no Quickstart to generate. Move it to the bottom and only link to GitHub and the Doxygen reference page.

Staged
http://192.241.195.202:9000/staging/java-sdk-jar-url/linux/developers/minio-drivers.html

Replace old JAR download link to the list of versions at Maven Central Repository.

The link on the Quickstart page (generated from minio/minio-java/README.md) uses |java-jar-url|, but this replacement doesn't work if used directly in rst files. Leaving that alone for now.
@feorlen
Copy link
Collaborator Author

feorlen commented Oct 26, 2023

Building with make SYNC_SDK=TRUE linux produces the expected URL ""https://repo1.maven.org/maven2/io/minio/minio/8.5.6/""

(All the substitutions go inside double double quotes, it seems.)

@ravindk89
Copy link
Collaborator

LGTM!

@feorlen feorlen merged commit d0a0ff1 into main Oct 26, 2023
@feorlen feorlen deleted the java-sdk-jar-url branch October 26, 2023 20:06
@feorlen
Copy link
Collaborator Author

feorlen commented Oct 26, 2023

Note: further improvements via #752

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants