Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put: Add --disable-multipart to make it easier to use. #5041

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

llchry
Copy link
Contributor

@llchry llchry commented Sep 24, 2024

put: Add --md5 and --disable-multipart to make it easier to use.

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Add --md5 and --disable-multipart for mc put action

Motivation and Context

Add --md5 and --disable-multipart for mc put action

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

put: Add --md5 and --disable-multipart to make it easier to use.
@klauspost
Copy link
Contributor

@harshavardhana @vadmeste @llchry I suggest we hold off on --md5.

I have added checksums to minio-go. While MD5 isn't a checksum in the same sense, it serves the same purpose. So it seems to me like --checksum=MD5|CRC32|CRC32C|SHA1|SHA256 would be a more sensible parameter from a user perspective?

@llchry llchry closed this Sep 24, 2024
@llchry llchry reopened this Sep 24, 2024
@llchry
Copy link
Contributor Author

llchry commented Sep 24, 2024

@harshavardhana @vadmeste @llchry I suggest we hold off on --md5.

I have added checksums to minio-go. While MD5 isn't a checksum in the same sense, it serves the same purpose. So it seems to me like --checksum=MD5|CRC32|CRC32C|SHA1|SHA256 would be a more sensible parameter from a user perspective?

Great,that's exactly what I wanted.

@klauspost
Copy link
Contributor

@llchry Just remove the MD5 part. I will do the checksum stuff, since it is a bit more involved. I will ping you on the PR when ready.

Remove md5 parameter on mc put  action, which will be replaced by checksum.
@llchry
Copy link
Contributor Author

llchry commented Sep 24, 2024

@llchry Just remove the MD5 part. I will do the checksum stuff, since it is a bit more involved. I will ping you on the PR when ready.

it has been removed. thanks

Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@klauspost
Copy link
Contributor

#5043 adds checksums across the deck.

@harshavardhana harshavardhana changed the title put: Add --md5 and --disable-multipart to make it easier to use. put: Add --disable-multipart to make it easier to use. Sep 24, 2024
@harshavardhana harshavardhana merged commit a5a54b4 into minio:master Sep 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants