Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit mc mirror when errors occur if retry is disabled and it's a watch operation #5163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jadolg
Copy link

@jadolg jadolg commented Mar 11, 2025

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

When running mc mirror --watch the cli exits with a non-zero exit code instead of just printing the error.

Motivation and Context

I'm running mc mirror --watch in a systemd unit to constantly mirror my minio buckets to AWS S3. In the current state, it's not possible to monitor mc effectively since the process will just continue running.

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@jadolg
Copy link
Author

jadolg commented Mar 11, 2025

Solves #5162

@jadolg jadolg marked this pull request as ready for review March 11, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant