Add Expires to PutObject opts #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadmeste
force-pushed
the
add-expires
branch
from
7d58f06 to
f9ca58b
Compare
harshavardhana
requested changes
Nov 19, 2023
Co-authored-by: Harshavardhana <[email protected]>
harshavardhana
approved these changes
Nov 19, 2023
oguzhand95
referenced
this pull request
in cerbos/cerbos
Nov 27, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/aws/aws-sdk-go](https://togithub.com/aws/aws-sdk-go) | require | patch | `v1.48.0` -> `v1.48.4` | | [github.com/cerbos/cerbos/api/genpb](https://togithub.com/cerbos/cerbos) | require | digest | `7dd5d0c` -> `ce425d9` | | [github.com/cerbos/protoc-gen-jsonschema](https://togithub.com/cerbos/protoc-gen-jsonschema) | require | patch | `v0.1.1` -> `v0.1.2` | | [github.com/doug-martin/goqu/v9](https://togithub.com/doug-martin/goqu) | require | minor | `v9.18.0` -> `v9.19.0` | | [github.com/minio/minio-go/v7](https://togithub.com/minio/minio-go) | require | patch | `v7.0.63` -> `v7.0.64` | | [github.com/pterm/pterm](https://togithub.com/pterm/pterm) | require | patch | `v0.12.70` -> `v0.12.71` | | [github.com/rivo/tview](https://togithub.com/rivo/tview) | require | digest | `7c9e464` -> `33a1d27` | | [github.com/vektra/mockery/v2](https://togithub.com/vektra/mockery) | require | minor | `v2.37.1` -> `v2.38.0` | | [google.golang.org/genproto/googleapis/api](https://togithub.com/googleapis/go-genproto) | require | digest | `bbf56f3` -> `83a465c` | | [google.golang.org/protobuf](https://togithub.com/protocolbuffers/protobuf-go) | require | digest | `a8317fb` -> `9b87403` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>aws/aws-sdk-go (github.com/aws/aws-sdk-go)</summary> ### [`v1.48.4`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v1484-2023-11-27) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.48.3...v1.48.4) \=== ##### Service Client Updates - `service/accessanalyzer`: Updates service API, documentation, and paginators - `service/amp`: Updates service API, documentation, waiters, and paginators - `service/bcm-data-exports`: Adds new service - `service/cloudtrail`: Updates service API and documentation - CloudTrail Lake now supports federating event data stores. giving users the ability to run queries against their event data using Amazon Athena. - `service/codestar-connections`: Updates service API, documentation, and paginators - `service/compute-optimizer`: Updates service API and documentation - `service/config`: Updates service API and documentation - `service/controltower`: Updates service API, documentation, and paginators - `service/cost-optimization-hub`: Adds new service - `service/detective`: Updates service API and documentation - `service/ecs`: Updates service API and documentation - Adds a new 'type' property to the Setting structure. Adds a new AccountSetting - guardDutyActivate for ECS. - `service/eks`: Updates service API, documentation, and paginators - `service/eks-auth`: Updates service API, documentation, waiters, paginators, and examples - `service/elasticfilesystem`: Updates service API, documentation, and paginators - Adding support for EFS Archive lifecycle configuration. - `service/elasticloadbalancingv2`: Updates service API, documentation, and paginators - `service/freetier`: Updates service API, documentation, paginators, and examples - `service/fsx`: Updates service API and documentation - `service/guardduty`: Updates service API and documentation - Add support for Runtime Monitoring for ECS and ECS-EC2. - `service/iotfleetwise`: Updates service API and documentation - `service/lakeformation`: Updates service API and documentation - `service/logs`: Updates service API, documentation, and paginators - Added APIs to Create, Update, Get, List and Delete LogAnomalyDetectors and List and Update Anomalies in Detector. Added LogGroupClass attribute for LogGroups to classify loggroup as Standard loggroup with all capabilities or InfrequentAccess loggroup with limited capabilities. - `service/managedblockchain`: Updates service API and documentation - `service/models.lex.v2`: Updates service API, documentation, and paginators - `service/personalize`: Updates service API and documentation - `service/personalize-events`: Updates service API and documentation - `service/personalize-runtime`: Updates service API and documentation - `service/quicksight`: Updates service API and documentation - This release launches new APIs for trusted identity propagation setup and supports creating datasources using trusted identity propagation as authentication method for QuickSight accounts configured with IAM Identity Center. - `service/redshift`: Updates service API and documentation - This release adds support for multi-data warehouse writes through data sharing. - `service/repostspace`: Adds new service - `service/runtime.lex.v2`: Updates service API and documentation - `service/s3`: Updates service API, documentation, and examples - Adding new params - Key and Prefix, to S3 API operations for supporting S3 Access Grants. Note - These updates will not change any of the existing S3 API functionality. - `service/s3control`: Updates service API, documentation, and paginators - Introduce Amazon S3 Access Grants, a new S3 access control feature that maps identities in directories such as Active Directory, or AWS Identity and Access Management (IAM) Principals, to datasets in S3. - `service/secretsmanager`: Updates service API, documentation, and paginators - AWS Secrets Manager has released the BatchGetSecretValue API, which allows customers to fetch up to 20 Secrets with a single request using a list of secret names or filters. - `service/securityhub`: Updates service API, documentation, and examples - `service/states`: Updates service API and documentation - Adds new TestState operation which accepts the definition of a single state and executes it. You can test a state without creating a state machine or updating an existing state machine. - `service/transcribe`: Updates service API and documentation - `service/workspaces`: Updates service API and documentation - The release introduces Multi-Region Resilience one-way data replication that allows you to replicate data from your primary WorkSpace to a standby WorkSpace in another AWS Region. DescribeWorkspaces now returns the status of data replication. - `service/workspaces-thin-client`: Adds new service ### [`v1.48.3`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v1483-2023-11-22) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.48.2...v1.48.3) \=== ##### Service Client Updates - `service/kinesis`: Updates service API and documentation - This release adds support for resource based policies on streams and consumers. - `service/s3control`: Updates service API and documentation - Amazon S3 Batch Operations now manages buckets or prefixes in a single step. - `service/sagemaker`: Updates service API and documentation - This feature adds the end user license agreement status as a model access configuration parameter. ### [`v1.48.2`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v1482-2023-11-21) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.48.1...v1.48.2) \=== ##### Service Client Updates - `service/cloudfront`: Updates service API, documentation, paginators, and examples - This release adds support for CloudFront KeyValueStore, a globally managed key value datastore associated with CloudFront Functions. - `service/cloudfront-keyvaluestore`: Adds new service - `service/ec2`: Updates service documentation - Documentation updates for Amazon EC2. - `service/inspector-scan`: Adds new service - `service/iotsitewise`: Updates service API, documentation, and paginators - `service/iottwinmaker`: Updates service API, documentation, and paginators - `service/s3`: Updates service API, documentation, and examples - Add support for automatic date based partitioning in S3 Server Access Logs. ### [`v1.48.1`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v1481-2023-11-20) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.48.0...v1.48.1) \=== ##### Service Client Updates - `service/codestar-connections`: Updates service API, documentation, and paginators - `service/docdb`: Updates service API and documentation - Amazon DocumentDB updates for new cluster storage configuration: Amazon DocumentDB I/O-Optimized. - `service/ec2`: Updates service API and documentation - This release adds support for Security group referencing over Transit gateways, enabling you to simplify Security group management and control of instance-to-instance traffic across VPCs that are connected by Transit gateway. </details> <details> <summary>cerbos/protoc-gen-jsonschema (github.com/cerbos/protoc-gen-jsonschema)</summary> ### [`v0.1.2`](https://togithub.com/cerbos/protoc-gen-jsonschema/compare/v0.1.1...v0.1.2) [Compare Source](https://togithub.com/cerbos/protoc-gen-jsonschema/compare/v0.1.1...v0.1.2) </details> <details> <summary>doug-martin/goqu (github.com/doug-martin/goqu/v9)</summary> ### [`v9.19.0`](https://togithub.com/doug-martin/goqu/blob/HEAD/HISTORY.md#v9190) [Compare Source](https://togithub.com/doug-martin/goqu/compare/v9.18.0...v9.19.0) - \[FEATURE] Add support for omitempty and omitnil struct tags [#​309](https://togithub.com/doug-martin/goqu/pull/309) - [@​randallmlough](https://togithub.com/randallmlough) </details> <details> <summary>minio/minio-go (github.com/minio/minio-go/v7)</summary> ### [`v7.0.64`](https://togithub.com/minio/minio-go/releases/tag/v7.0.64): Bugfix release [Compare Source](https://togithub.com/minio/minio-go/compare/v7.0.63...v7.0.64) #### What's Changed - Added new supported Bucket Event types by [@​bexsoft](https://togithub.com/bexsoft) in [https://github.com/minio/minio-go/pull/1885](https://togithub.com/minio/minio-go/pull/1885) - Support External Id and Session Token by [@​ekristen](https://togithub.com/ekristen) in [https://github.com/minio/minio-go/pull/1887](https://togithub.com/minio/minio-go/pull/1887) - Link to godoc by [@​klauspost](https://togithub.com/klauspost) in [https://github.com/minio/minio-go/pull/1894](https://togithub.com/minio/minio-go/pull/1894) - Bump golang.org/x/net from 0.14.0 to 0.17.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/minio/minio-go/pull/1889](https://togithub.com/minio/minio-go/pull/1889) - Bump golang.org/x/net from 0.14.0 to 0.17.0 in /examples/minio by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/minio/minio-go/pull/1888](https://togithub.com/minio/minio-go/pull/1888) - Update s3-endpoints.go: add il-central-1 by [@​emaildanwilson](https://togithub.com/emaildanwilson) in [https://github.com/minio/minio-go/pull/1886](https://togithub.com/minio/minio-go/pull/1886) - Update the Go Quickstart README by [@​feorlen](https://togithub.com/feorlen) in [https://github.com/minio/minio-go/pull/1896](https://togithub.com/minio/minio-go/pull/1896) - Add Expires to PutObject opts by [@​vadmeste](https://togithub.com/vadmeste) in [https://github.com/minio/minio-go/pull/1900](https://togithub.com/minio/minio-go/pull/1900) - snowball: Support per object advanced PUT options by [@​vadmeste](https://togithub.com/vadmeste) in [https://github.com/minio/minio-go/pull/1901](https://togithub.com/minio/minio-go/pull/1901) #### New Contributors - [@​ekristen](https://togithub.com/ekristen) made their first contribution in [https://github.com/minio/minio-go/pull/1887](https://togithub.com/minio/minio-go/pull/1887) - [@​dependabot](https://togithub.com/dependabot) made their first contribution in [https://github.com/minio/minio-go/pull/1889](https://togithub.com/minio/minio-go/pull/1889) - [@​emaildanwilson](https://togithub.com/emaildanwilson) made their first contribution in [https://github.com/minio/minio-go/pull/1886](https://togithub.com/minio/minio-go/pull/1886) - [@​feorlen](https://togithub.com/feorlen) made their first contribution in [https://github.com/minio/minio-go/pull/1896](https://togithub.com/minio/minio-go/pull/1896) **Full Changelog**: minio/minio-go@v7.0.63...v7.0.64 </details> <details> <summary>pterm/pterm (github.com/pterm/pterm)</summary> ### [`v0.12.71`](https://togithub.com/pterm/pterm/releases/tag/v0.12.71) [Compare Source](https://togithub.com/pterm/pterm/compare/v0.12.70...v0.12.71) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### Fixes 🔧 - fix(BulletList): indentation does not work when the item has a linebreak by [@​MarvinJWendt](https://togithub.com/MarvinJWendt) in [https://github.com/pterm/pterm/pull/589](https://togithub.com/pterm/pterm/pull/589) **Full Changelog**: pterm/pterm@v0.12.70...v0.12.71 </details> <details> <summary>vektra/mockery (github.com/vektra/mockery/v2)</summary> ### [`v2.38.0`](https://togithub.com/vektra/mockery/releases/tag/v2.38.0) [Compare Source](https://togithub.com/vektra/mockery/compare/v2.37.1...v2.38.0) #### Changelog - [`446e0bf`](https://togithub.com/vektra/mockery/commit/446e0bf) Merge pull request [#​736](https://togithub.com/vektra/mockery/issues/736) from mateusmarquezini/issue\_729 - [`445f73c`](https://togithub.com/vektra/mockery/commit/445f73c) added new check for no return values - [`8e778e0`](https://togithub.com/vektra/mockery/commit/8e778e0) created a new test to cover the new condition when the test panics [#​729](https://togithub.com/vektra/mockery/issues/729) - [`d0fa1f9`](https://togithub.com/vektra/mockery/commit/d0fa1f9) improvements after code review [#​729](https://togithub.com/vektra/mockery/issues/729) - [`432134c`](https://togithub.com/vektra/mockery/commit/432134c) improvements after code review [#​729](https://togithub.com/vektra/mockery/issues/729) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cerbos/cerbos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Oğuzhan Durgun <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Oğuzhan Durgun <[email protected]>
](https://renovatebot.com){kind=link}
|
I tried using this option but its not working |
|
@MB175 What do you mean? Is the header not set? At least provide all the relevant information, if you want us to look into this. |
|
@klauspost I just did it looks like the header is set correctly also the "Expires" field is set. Looks like the issue lies within my minio server which is still serving the file after expiration strange enough. So no worries your changes work as expected, sorry for the disturbance |
|
@MB175 The header has no functional meaning other than being stored on the object. It can be picked up by proxies, etc. MinIO will do nothing more than store it and return whatever value it was set to. It is not a TTL. See Object Lifecycle Management on how to expire objects via lifecycle. This is similar to AWS S3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Expires field while uploading an object