NEW API: GetObjectAttributes

[zveinn]

This PR is related to minio/minio#18732

P.s. the CI/CD tests will fail until we update the main repo with the new endpoint.

[klauspost]

IMO you should make this easier to use and abstract away the overly complicated parts (pun not intended, but nice).

[zveinn]

IMO you should make this easier to use and abstract away the overly complicated parts (pun not intended, but nice).

The api has been simplified based on our discussion today, I will double check AWS behavior tomorrow when it comes to large part numbers.

[klauspost]

Just unexport the const. LGTM otherwise.

[klauspost]

@zveinn

Running lint check
Error: api-get-object-attributes.go:65:1: exported: comment on exported type ObjectAttributePart should be of the form "ObjectAttributePart ..." (with optional leading article) (revive)
// ObjectAttributesResponse ...
^
Error: constants.go:63:2: exported: exported const GetObjectAttributesTags should have comment (or a comment on this block) or be unexported (revive)
	GetObjectAttributesTags = "ETag,Checksum,StorageClass,ObjectSize,ObjectParts"
	^
Error: make: *** [Makefile:15: lint] Error 1

(this could indicate that errors are not handled correctly).

[klauspost]

@zveinn

Kinda interesting this gets thrown...

{"args":{"bucketName":"minio-go-test-rizxvdf5fd4dqwbk","objectName":"file2","opts":"minio.ObjectAttributesOptions{}"},"duration":6607,"error":"XML syntax error on line 1: invalid UTF-8","function":"GetObjectAttributes(ctx, bucketName, objectName, opts)","message":"GetObjectAttributes failed","name":"minio-go: testGetObjectAttributes","status":"FAIL"}

[klauspost]

I guess for older versions it returns the object data?

Kinda clunky API-wise, but I guess AWS overloaded the GET bucket/object to implement this...

We should probably document that this is the behavior (if it is) when the API call isn't supported by the remote.. Maybe we should even check the response content type or something similar before decoding.

[harshavardhana]

Something is broken in the tests as well now because in this PR master branch runs fine with MinIO latest release.

{"args":{"bucketName":"minio-go-test-riqvc9tscw0inoj5","contentType":"","filePath":"","metadata":"custom/contenttype","objectName":"ugqepx3npjrsgnzcb1940qnoiikd5y","sse":{}},"duration":62,"function":"FPutEncryptedObject(bucketName, objectName, filePath, contentType, sse)","name":"minio-go: testSSES3EncryptionFPut","status":"PASS"}
{"args":{"bucketName":"minio-go-test-t1jmaabgxw9mey3i","objectName":"v33nnuhfn0gdkz1wbqjhmsx3gjn6gx"},"duration":4491,"function":"GetObject(bucketName, objectName)","name":"minio-go: testSSES3EncryptedGetObjectReadAtFunctional","status":"PASS"}
{"args":{"bucketName":"minio-go-test-3v21332559zpfsz4","objectName":"ob2ojnkoranpdpgvf5tsnnqch0vjgc"},"duration":7785,"function":"GetObject(bucketName, objectName)","name":"minio-go: testSSES3EncryptedGetObjectReadSeekFunctional","status":"PASS"}
{"args":{"destination":{"Bucket":"minio-go-test-rplpr2u4nzbis0ct","Object":"srcObject","Encryption":null,"UserMetadata":null,"ReplaceMetadata":false,"UserTags":null,"ReplaceTags":false,"LegalHold":"","Mode":"","RetainUntilDate":"0001-01-01T00:00:00Z","Size":0,"Progress":null},"source":{"Bucket":"minio-go-test-rplpr2u4nzbis0ct","Object":"srcObject","VersionID":"","MatchETag":"","NoMatchETag":"","MatchModifiedSince":"0001-01-01T00:00:00Z","MatchUnmodifiedSince":"0001-01-01T00:00:00Z","MatchRange":false,"Start":0,"End":0,"Encryption":{}}},"duration":262,"function":"CopyObject(destination, source)","name":"minio-go: testEncryptedSSES3ToSSES3CopyObject","status":"PASS"}
{"args":{"destination":{"Bucket":"minio-go-test-9q30ubdszad5fhmk","Object":"srcObject","Encryption":null,"UserMetadata":null,"ReplaceMetadata":false,"UserTags":null,"ReplaceTags":false,"LegalHold":"","Mode":"","RetainUntilDate":"0001-01-01T00:00:00Z","Size":0,"Progress":null},"source":{"Bucket":"minio-go-test-9q30ubdszad5fhmk","Object":"srcObject","VersionID":"","MatchETag":"","NoMatchETag":"","MatchModifiedSince":"0001-01-01T00:00:00Z","MatchUnmodifiedSince":"0001-01-01T00:00:00Z","MatchRange":false,"Start":0,"End":0,"Encryption":{}}},"duration":261,"function":"CopyObject(destination, source)","name":"minio-go: testEncryptedSSES3ToUnencryptedCopyObject","status":"PASS"}
{"args":{"destination":{"Bucket":"minio-go-test-1kleakxixnvtqvnj","Object":"dstObject","Encryption":{},"UserMetadata":null,"ReplaceMetadata":false,"UserTags":null,"ReplaceTags":false,"LegalHold":"","Mode":"","RetainUntilDate":"0001-01-01T00:00:00Z","Size":0,"Progress":null},"source":{"Bucket":"minio-go-test-1kleakxixnvtqvnj","Object":"srcObject","VersionID":"","MatchETag":"","NoMatchETag":"","MatchModifiedSince":"0001-01-01T00:00:00Z","MatchUnmodifiedSince":"0001-01-01T00:00:00Z","MatchRange":false,"Start":0,"End":0,"Encryption":null}},"duration":233,"function":"CopyObject(destination, source)","name":"minio-go: testUnencryptedToSSES3CopyObject","status":"PASS"}
{"args":{},"duration":151,"function":"CopyObjectPart(destination, source)","name":"minio-go: testUnencryptedToSSES3CopyObjectPart","status":"PASS"}
{"args":{},"duration":135,"function":"CopyObjectPart(destination, source)","name":"minio-go: testSSES3EncryptedToUnencryptedCopyPart","status":"PASS"}
{"args":{},"duration":169,"function":"CopyObjectPart(destination, source)","name":"minio-go: testSSES3EncryptedToSSES3CopyObjectPart","status":"PASS"}

However this PR is passing GetObjectAttributes but failing in other places.

[klauspost]

Lovely! <3