-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add header for lifecycle config expiry to ignore replication #1999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't bucket replication configuration a better place where we put this config ?
this setting is for ILM to expire unreplicated versions or not - it belongs here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand. Why are we sending a config value as a header?
ef88c47
to
c5af76b
Compare
@@ -127,4 +127,7 @@ const ( | |||
minioTgtReplicationReady = "X-Minio-Replication-Ready" | |||
// Header asks if delete marker replication request can be sent by source now. | |||
isMinioTgtReplicationReady = "X-Minio-Check-Replication-Ready" | |||
|
|||
// Header indicating if ilm expiry ignores replication status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Header indicates if ILM expiration must trigger after replication
PTAL @vadmeste @krisis @klauspost |
No description provided.