-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PromptObject API support #2015
Merged
Merged
PromptObject API support #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested changes
Nov 1, 2024
sidharthrajaram
force-pushed
the
add-prompt-obj
branch
2 times, most recently
from
November 1, 2024 10:29
849e3a8
to
1ce6776
Compare
klauspost
reviewed
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly trying to get stuff ironed out before the API is fixed.
harshavardhana
requested changes
Nov 1, 2024
fwessels
reviewed
Nov 1, 2024
sidharthrajaram
force-pushed
the
add-prompt-obj
branch
from
November 1, 2024 19:00
1ce6776
to
8c64444
Compare
harshavardhana
approved these changes
Nov 1, 2024
fwessels
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
promptObject API support
PromptObject
is the function.PromptObjectOptions
can (optionally) contain the targetLambdaArn
and anyPromptArgs
for inference (similar tokwargs
in the Python SDK for any arguments liketemperature
,response_format
,max_tokens
, etc.).`