Enable optional Redirect Handling Support #2021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klauspost
requested changes
Nov 19, 2024
There was a problem hiding this comment.
I don't want this controlled by an env var, since it triggers re-signing to a different host, it would make requests be signed to a remote controlled host.
While the security aspect is very minimal, it should be determined by the caller application if that risk is acceptable and not be accepted based purely external factors.
Comment on lines
+312
to
+315
| if envValue := os.Getenv("ENABLE_REDIRECT_HANDLING"); envValue == "true" { | ||
| clnt.httpClient.CheckRedirect = clnt.redirectHeaders | ||
| } | ||
|
|
There was a problem hiding this comment.
Don't add env vars to a library. Add it to the Options.
|
Redirect is not supported in S3 API, it simply doesn't work correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle Issue - #2016
References: