Fix for tests running in mint vs locally #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marktheunissen
force-pushed
the
checksum-test-fix
branch
from
e57e793 to
57839e3
Compare
harshavardhana
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running functional tests locally,
getDataReaderreturns some stable data, however when calling the same function from within themintdocker image, the sample data it returns was generated by a script calledcreate-data-files.shand placed inMINT_DATA_DIR. Thus the checksum is different, causing a test failure.This PR switches out usage of the data file, for a simple
ChecksumBytes([]byte{0x01, 0x02, 0x03})which is a stable checksum and is faster.I don't think this is the fix for the failure we see here, which is a different test: https://github.com/minio/minio/actions/runs/12135560142/job/33866257119?pr=20674 , however it's something that failed for me locally.