Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: notification.ts #1226

Merged
merged 28 commits into from
Dec 13, 2023
Merged

refactor: notification.ts #1226

merged 28 commits into from
Dec 13, 2023

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Nov 3, 2023

No description provided.

@trim21 trim21 marked this pull request as ready for review November 3, 2023 15:36
@trim21 trim21 marked this pull request as draft November 3, 2023 19:46
@trim21 trim21 closed this Nov 4, 2023
@trim21 trim21 reopened this Nov 14, 2023
@trim21 trim21 mentioned this pull request Nov 20, 2023
Merged
@trim21 trim21 marked this pull request as ready for review November 22, 2023 11:13
aldy505
aldy505 reviewed Nov 24, 2023
View reviewed changes
Copy link
Contributor

@aldy505 aldy505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

trim21
trim21 commented Nov 28, 2023
View reviewed changes
src/minio.js Outdated Show resolved Hide resolved
trim21
trim21 commented Nov 28, 2023
View reviewed changes
src/minio.js Outdated Show resolved Hide resolved
trim21
trim21 commented Nov 28, 2023
View reviewed changes
src/minio.js Outdated Show resolved Hide resolved
trim21
trim21 commented Dec 8, 2023
View reviewed changes
src/minio.d.ts Outdated Show resolved Hide resolved
@trim21
Copy link
Contributor Author

trim21 commented Dec 8, 2023

@prakashsvmx

@trim21
Copy link
Contributor Author

trim21 commented Dec 9, 2023

@kaankabalak

@prakashsvmx
Copy link
Member

@trim21 , could you please rename examples/minio/listen-bucket-notification.js to examples/minio/listen-bucket-notification.mjs ?

@trim21
Copy link
Contributor Author

trim21 commented Dec 11, 2023

@trim21 , could you please rename examples/minio/listen-bucket-notification.js to examples/minio/listen-bucket-notification.mjs ?

This file is not touched

@aldy505
Copy link
Contributor

aldy505 commented Dec 11, 2023

@trim21 , could you please rename examples/minio/listen-bucket-notification.js to examples/minio/listen-bucket-notification.mjs ?

@prakashsvmx I think changing the example is better be done at #1236 or in another separate PR. We should be more focused on refactoring the project to Typescript first. Then after some refactored code got merged, we can work on the examples, then create a new release. It should be faster than changing the example alongside the code, while having to go back and forth resolving merge conflict everytime a certain PR got merged.

@trim21
Copy link
Contributor Author

trim21 commented Dec 11, 2023

@kaankabalak

@trim21 trim21 requested a review from prakashsvmx December 12, 2023 20:00
@prakashsvmx prakashsvmx merged commit b109cdb into minio:master Dec 13, 2023
14 checks passed
@trim21 trim21 deleted the notification branch December 13, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldy505 aldy505 aldy505 left review comments

@kaankabalak kaankabalak kaankabalak approved these changes

@prakashsvmx prakashsvmx Awaiting requested review from prakashsvmx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trim21 @prakashsvmx @aldy505 @kaankabalak