-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow existing secret #2299
Allow existing secret #2299
Conversation
When would this be released? |
@ramondeklein don't we need by chance to comment out When I upgrade my minio-tenant release to
I'm failing validation:
Setting these fields explicitly to empty values solves the problem. |
Could we take the opportunity to allow the helm to generate random user and password when not provided? |
@@ -15,6 +16,14 @@ stringData: | |||
export MINIO_ROOT_USER={{ .Values.tenant.configSecret.accessKey | quote }} | |||
export MINIO_ROOT_PASSWORD={{ .Values.tenant.configSecret.secretKey | quote }} | |||
|
|||
{{- else }} | |||
{{- if (.Values.tenant.configSecret.accessKey) }} | |||
{{- fail "# ERROR: cannot set access-key when an existing secret is used" }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of these checks, you have to set the accessKey and secretKey values to zero when you enable existingSecret, since they already set in main values.
Perhaps it would be better to remove these checks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, I've got a PR to try and fix this but it's been sat since October 😬
Allow specifying
s.tenant.configSecret.existingSecret
in the Helm chart to prevent creating a new certificate.Fixes #2297 and #2298.