-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get: Add --range-size to have a random but a defined range pattern #302
Conversation
We can discuss during the next week if we should drop this PR or not @klauspost |
Lint fix at: #303 |
cli/get.go
Outdated
cli.StringFlag{ | ||
Name: "obj.name", | ||
Usage: "Specify an object name", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of keeping this simple - could you explain why this is needed?
It seems like it would break pretty much all scenarios since they upload multiple objects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is originally written to benchmark server caching, so warp clients will read the same object multiple times, but yeah I think it is better if we make the orchestor warp client to generate a list of objects and share it with other warp clients before starting to benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The multipart benchmark does this already:
Line 94 in 1723cdb
b.ExtraFlags = map[string]string{"_upload-id": b.UploadID, "noprefix": "true"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want the initiator to create the objects - otherwise they will all be fighting to create it.
Note however that this will invalidate the PUT benchmark. TBH I just think you want to remove this and just have each client upload a few objects.
is this PR still planned? if not please close. |
@vadmeste Reach out if you still need it, and I can adjust it as needed. |
we have a customer requirement on this can we finalize this ? |
What is the point of the single object name? You can use |
The requirement is that have a bunch of large objects for example and then you can specify a range warp decides to generate list of range requests that randomly hit these objects and provide results, that's all. |
@harshavardhana Yes. But not sure why the custom name would be needed for that (and it will break in distributed). To me it seems like it should just be removed from this PR. |
--range-size will create a random offset but with a fixed range
a1fe84f
to
30d35d1
Compare
--range-size and --range will create GET requests with random offset but with fixed range