Merge pull request #14 from ministryofjustice/feature/interpolate-acc…

…ount-id Replace account id
ministryofjustice · Mar 27, 2019 · f28ea0f · f28ea0f
2 parents 1d8821d + beb6036
commit f28ea0f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/examples/main.tf b/examples/main.tf
@@ -13,7 +13,7 @@ provider "aws" {
  *
  */
 module "example_team_ecr_credentials" {
-  source     = "github.com/ministryofjustice/cloud-platform-terraform-ecr-credentials?ref=3.0"
+  source     = "github.com/ministryofjustice/cloud-platform-terraform-ecr-credentials?ref=3.1"
   repo_name  = "example-module"
   team_name  = "example-team"
   aws_region = "eu-west-2"                                                                     # this overwrite the region from the provider defined above. 

diff --git a/main.tf b/main.tf
@@ -76,7 +76,7 @@ data "aws_iam_policy_document" "policy" {
     ]
 
     resources = [
-      "arn:aws:ecr:eu-west-1:926803513772:repository/${var.team_name}/*",
+      "arn:aws:ecr:${var.aws_region}:${data.aws_caller_identity.current.account_id}:repository/${var.team_name}/*",
     ]
   }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -76,7 +76,7 @@ data "aws_iam_policy_document" "policy" { @@
         ]
         resources = [
-          "arn:aws:ecr:eu-west-1:926803513772:repository/${var.team_name}/*",
+          "arn:aws:ecr:${var.aws_region}:${data.aws_caller_identity.current.account_id}:repository/${var.team_name}/*",
         ]
       }
     }
@@ Expand Down @@