Repo vars condition #109
Merged
Repo vars condition #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| @@ -4,7 +4,9 @@ | |||
|
|
|||
| This Terraform module will create an [Amazon Elastic Container Registry](https://aws.amazon.com/ecr/) private repository for use on the Cloud Platform. | |||
|
|
|||
| If you're using GitHub as your OIDC provider, this module will automatically create the required variables for authentication in your GitHub repository. | |||
| If you're using GitHub as your OIDC provider, this module will automatically create the required variables for authentication in your GitHub repository. By default these will be created as [repository secrets and variables](https://docs.github.com/en/actions/learn-github-actions/variables#creating-configuration-variables-for-a-repository). Optionally, you can configure the module to create the ECR secrets | |||
There was a problem hiding this comment.
Optionally sounds like additionally. Can we say something like, if you have defined GitHub Environments, you can configure the module to create the ECR secrets and variables into your own defined Github Environment and not as a Github repository secrets. This can be done by passing the github_environments with the value you defined for your Github environment.
There was a problem hiding this comment.
Good point, I've updated it. Hopefully that clarifies the difference?
poornima-krishnasamy
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.