Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: ⚡️ pass in the ability to configure proxy-buffering #85

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

jaskaransarkaria
Copy link
Contributor

When proxy buffering is disabled, NGINX buffers only the first part of a server’s response before starting to send it to the client, in a buffer that by default is one memory page in size (4 KB or 8 KB depending on the operating system). This is usually just enough space for the response header. NGINX then sends the response to the client synchronously as it receives it, forcing the server to sit idle as it waits until NGINX can accept the next response segment. 

proxy-buffering is off by default

https://github.com/kubernetes/ingress-nginx/blob/main/docs/user-guide/nginx-configuration/configmap.md#configuration-options

https://www.nginx.com/blog/avoiding-top-10-nginx-configuration-mistakes/#proxy_buffering-off

@jaskaransarkaria jaskaransarkaria force-pushed the add-proxy-response-buffering branch from b279e83 to 9b31f2b Compare March 19, 2024 14:32
@jaskaransarkaria jaskaransarkaria merged commit dcd4c04 into main Mar 19, 2024
@jaskaransarkaria jaskaransarkaria deleted the add-proxy-response-buffering branch March 19, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants