remove-kuberhealthy-dns-status-alert #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikebell
approved these changes
Nov 21, 2023
…SStatusCheckInternal-query-until-check-properly-set-up
pwyborn
deleted the
remove-KuberhealthyDNSStatusCheckInternal-query-until-check-properly-set-up
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Remove
KuberhealthyDNSStatusCheckInternalalertKuberhealthyOverallClusterStateCheck Alert - output information as to which of the Kuberhealthy alerts has failed#4844
Also with reference to new ticket:
KuberhealthyDNSStatusCheck (dns-status)- investigate whether we need - Internal and/or External #5035.
Basically the actual check:
dns-status-internal- has not been been customised for our own use, and it is at present only reporting on Kuberhealthy itself. Ticket above therefore to investigate whether this (and or External DNS check) are needed - if yes customise and revisit the alert.