Skip to content

Commit

Permalink
Revert dynamic "parameter" changes
Browse files Browse the repository at this point in the history
As this change will effect the existing RDS users,
who use "force_ssl" and "pending-reboot"
  • Loading branch information
vijay-veeranki committed Mar 13, 2020
1 parent 19dc44a commit 967e42b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 23 deletions.
11 changes: 4 additions & 7 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -127,13 +127,10 @@ resource "aws_db_parameter_group" "custom_parameters" {
name = local.identifier
family = var.rds_family

dynamic "parameter" {
for_each = var.db_parameter
content {
apply_method = lookup(parameter.value, "apply_method", null)
name = parameter.value.name
value = parameter.value.value
}
parameter {
name = "rds.force_ssl"
value = var.force_ssl ? 1 : 0
apply_method = var.apply_method
}
}

Expand Down
16 changes: 0 additions & 16 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -91,22 +91,6 @@ variable "ca_cert_identifier" {
default = "rds-ca-2019"
}

variable "db_parameter" {
type = list(object({
apply_method = string
name = string
value = string
}))
default = [
{
name = "rds.force_ssl"
value = "true"
apply_method = "immediate"
}
]
description = "A list of DB parameters to apply. Note that parameters may differ from a DB family to another"
}

variable "performance_insights_enabled" {
type = bool
description = "Enable performance insights for RDS?"
Expand Down

0 comments on commit 967e42b

Please sign in to comment.