chore: 🤖 fix conditional check for replica db name and engine version #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: 🤖 wip chore: 🤖 wip
sj-williams
changed the title
tom-j-smith
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to ministryofjustice/cloud-platform#6068
This PR updates our RDS module to reflect changes that were made to the AWS provider in
4.63concerning re-enabling engine version setting for read replicas:hashicorp/terraform-provider-aws#24887
This is necessary for CP users who are manually (not auto minor upgrading) their RDS configurations where they have a primary and a replica.
In this case the user must be able to set the minor version for their replica and carry out this prior to completing the minor version upgrade of their primary RDS.