Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eks subnet sgs #179

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Eks subnet sgs #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8752b36
feat: 🎸 add new eks subnets to rds security groups
sj-williams Sep 11, 2024
1382ea6
terraform-docs: automated action
github-actions[bot] Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,9 @@ No modules.
| [aws_caller_identity.current](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/caller_identity) | data source |
| [aws_iam_policy_document.irsa](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/iam_policy_document) | data source |
| [aws_region.current](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/region) | data source |
| [aws_subnet.eks_private](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/subnet) | data source |
| [aws_subnet.private](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/subnet) | data source |
| [aws_subnets.eks_private](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/subnets) | data source |
| [aws_subnets.private](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/subnets) | data source |
| [aws_vpc.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/vpc) | data source |

Expand Down
28 changes: 25 additions & 3 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,22 @@ data "aws_subnet" "private" {
id = each.value
}

data "aws_subnets" "eks_private" {
filter {
name = "vpc-id"
values = [data.aws_vpc.this.id]
}

tags = {
SubnetType = "EKS-Private"
}
}

data "aws_subnet" "eks_private" {
for_each = toset(data.aws_subnets.eks_private.ids)
id = each.value
}

########################
# Generate identifiers #
########################
Expand Down Expand Up @@ -123,18 +139,24 @@ resource "aws_security_group" "rds-sg" {
# cyclic dependency. Rather than resorting to `aws_security_group_rule` which
# is not ideal for managing rules, we will simply allow traffic to all ports.
# This does not compromise security as the instance only listens on one port.
ingress {
ingress {
from_port = 0
to_port = 0
protocol = "-1"
cidr_blocks = [for s in data.aws_subnet.private : s.cidr_block]
cidr_blocks = concat(
[for s in data.aws_subnet.private : s.cidr_block],
[for s in data.aws_subnet.eks_private : s.cidr_block]
)
}

egress {
from_port = 0
to_port = 0
protocol = "-1"
cidr_blocks = [for s in data.aws_subnet.private : s.cidr_block]
cidr_blocks = concat(
[for s in data.aws_subnet.private : s.cidr_block],
[for s in data.aws_subnet.eks_private : s.cidr_block]
)
}
}

Expand Down