Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APS-1314 - Return User's CRU Management Area details in the API #2315

Merged

Conversation

davidatkinsuk
Copy link
Contributor

@davidatkinsuk davidatkinsuk commented Sep 24, 2024

This commit adds CRU Management Area fields to the ApprovedPremisesUser API Model to support:

  • Determining which CRU Management Area the user is in (when retrieved via /profile/v2)
  • Logic to determine/set/get override configuration for the user management page

This commit is quite large because i had fix existing test data where entries in the users table were created for CAS1 testing and the CRU Management Area was not set, something which wouldn’t be the case in production (it’s logically mandatory for CAS1 users)

@davidatkinsuk davidatkinsuk force-pushed the feature/aps-1314-update-api-to-return-user-area-details branch 3 times, most recently from ed52bfb to a93b17c Compare September 24, 2024 10:10
@davidatkinsuk davidatkinsuk changed the title Feature/aps 1314 update api to return user area details APS-1314 - Update CAS1 API to return CRU Management Area details Sep 24, 2024
@davidatkinsuk davidatkinsuk force-pushed the feature/aps-1314-update-api-to-return-user-area-details branch from a93b17c to 9b98e4b Compare September 25, 2024 08:29
@davidatkinsuk davidatkinsuk marked this pull request as ready for review September 25, 2024 08:31
@davidatkinsuk davidatkinsuk force-pushed the feature/aps-1314-update-api-to-return-user-area-details branch from 9b98e4b to c48f74a Compare September 25, 2024 08:31
@davidatkinsuk davidatkinsuk changed the title APS-1314 - Update CAS1 API to return CRU Management Area details APS-1314 - Return User's CRU Management Area details in the API Sep 25, 2024
@davidatkinsuk davidatkinsuk force-pushed the feature/aps-1314-update-api-to-return-user-area-details branch 4 times, most recently from 17573b5 to 4dcc1a1 Compare September 26, 2024 15:02
Copy link
Contributor

@RobBoothMOJ RobBoothMOJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@davidatkinsuk davidatkinsuk force-pushed the feature/aps-1314-update-api-to-return-user-area-details branch 4 times, most recently from 24f74d2 to ca8a6f8 Compare September 30, 2024 13:19
This commit adds CRU Management Area fields to the ApprovedPremisesUser API Model to support:

* Determining which CRU Management Area the user is in (when retrieved via /profile/v2)
* Logic to determine/set/get override configuration for the user management page

This commit is quite large because i had fix existing test data where entries in the users table were created for CAS1 testing and the CRU Management Area was not set, something which wouldn’t be the case in production (it’s logically mandatory for CAS1 users).
@davidatkinsuk davidatkinsuk force-pushed the feature/aps-1314-update-api-to-return-user-area-details branch from ca8a6f8 to 8a33399 Compare September 30, 2024 13:58
@davidatkinsuk davidatkinsuk merged commit db4e2a2 into main Sep 30, 2024
7 of 8 checks passed
@davidatkinsuk davidatkinsuk deleted the feature/aps-1314-update-api-to-return-user-area-details branch September 30, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants