Cas2v2 user entity #2793
Open
Cas2v2 user entity #2793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
cas2v2/cba-83_create-a-new-cas2v2-namespace
to
cas2v2/dev
January 14, 2025 13:40
rossjones-moj
force-pushed
the
cas2v2/users
branch
from
cae752a to
1e82520
Compare
rossjones-moj
commented
Jan 15, 2025
...n/uk/gov/justice/digital/hmpps/approvedpremisesapi/service/cas2v2/Cas2v2UserAccessService.kt
Outdated
Show resolved
Hide resolved
rossjones-moj
force-pushed
the
cas2v2/users
branch
6 times, most recently
from
c95c494 to
d680870
Compare
rossjones-moj
force-pushed
the
cas2v2/users
branch
from
aaa941f to
843c9e4
Compare
rossjones-moj
force-pushed
the
cas2v2/users
branch
3 times, most recently
from
12374c7 to
7c40cb3
Compare
rossjones-moj
force-pushed
the
cas2v2/users
branch
from
117ecec to
87572f4
Compare
rossjones-moj
requested review from
davidatkinsuk
and removed request for
garethCAS2 and
tobybatchmoj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new entity for Cas2v2 users where all user types are represented in a single entity (Cas2v2UserEntity) and differentiated by the
userTypefield which is aCas2v2UserTypecontaining the different allowed user types for Cas2v2.As a result of the change, all of the Cas2v2 classes that contain users have been changed to use the new type instead of NomisUserEntity/UserEntity/ExternalUserEntity. This removes a dependence on the Cas2 entities but should still allow a future migration to use the entities in this namespace.
This PR also introduces a CAS2V2
ServiceNamewhich is used to ensure that a Cas2v2Application is used instead of Application or Cas2Application when calling APIs.DomainEvents remain as cas2 domain events with no change