spike/CAS-1341-CAS2-Prison-Transfer-Event-Emit-POC #2834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
besscerule
changed the title
| @@ -64,6 +64,10 @@ generic-service: | |||
| elasticache-redis: | |||
| SPRING_DATA_REDIS_HOST: "primary_endpoint_address" | |||
| SPRING_DATA_REDIS_PASSWORD: "auth_token" | |||
| inbound-queue-sqs-instance-output: | |||
| HMPPS_SQS_QUEUES_INBOUNDQUEUE_QUEUE_NAME: "inboundqueue" | |||
There was a problem hiding this comment.
Is there a specific reason this isn't either camel or snake case?
There was a problem hiding this comment.
besscerule
force-pushed
the
spike/CAS-1341-CAS2-Prison-Transfer-Event-Emit-POC
branch
2 times, most recently
from
bc64d4d to
f2a191a
Compare
...kotlin/uk/gov/justice/digital/hmpps/approvedpremisesapi/integration/cas2/InboundQueueTest.kt
Show resolved
Hide resolved
| fun `Put Message on Inbound Queue Request is successful`() { | ||
| putMessageOnInboundQueue() | ||
| TimeUnit.MILLISECONDS.sleep(10000) | ||
| verify(exactly = 1) { mockMessageListener.processMessage(any()) } |
There was a problem hiding this comment.
again, probably not an issue as this is POC but a library like awaitility would let us remove this sleep. I'm not sure if there's a more kotlin way of doing it though!
There was a problem hiding this comment.
I'm not sure we even need the sleep tbf
There was a problem hiding this comment.
ahh yes we do! fails when i remove!
This is a POC branch to demonstrate how to set up a listener for the domain events topic. Message Listener listens to the inboundQueue which is filtered by the allocation and handover event types and prints out the message. You can run it locally and send messages using the scripts found in test-messages in the test resources folder. It has a simple Integration test that checks that the listener was called and also a tests to check the health of the queue.
besscerule
force-pushed
the
spike/CAS-1341-CAS2-Prison-Transfer-Event-Emit-POC
branch
from
f2a191a to
f422f8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a POC branch to demonstrate how to set up a listener for the domain events topic.
Message Listener listens to the inboundQueue which is filtered by the allocation and handover event types and prints out the message.
You can run it locally and send messages using the scripts found in test-messages in the test resources folder.
It has a simple Integration test that checks that the listener was called and also a tests to check the health of the queue.