-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigate to placeholder occupancy view #2213
Navigate to placeholder occupancy view #2213
Conversation
6f32035
to
df26491
Compare
server/controllers/match/placementRequests/occupancyViewController.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, couple of comments!
5d1ebd9
to
c83839f
Compare
c83839f
to
9fd323c
Compare
<h1 class="govuk-heading-l">{{ pageHeading }}</h1> | ||
<a class="govuk-button" href="{{ MatchUtils.redirectToSpaceBookingsNew({placementRequestId: placementRequest.id, premisesName: premisesName, premisesId: premisesId, apType: apType, startDate: startDate, durationDays: durationDays }) }}"> | ||
Continue | ||
</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bobmeredith @froddd in the long run (based on the Occupancy view designs) we will have "Continue" button within a "Book you placement" form that submits the date values entered into the form.
This is out of scope for this ticket, so for now I have just created an anchor link that redirects them back into the flow as per suggestion.
Hopefully an anchor link (not a button) will suffice for now? As you guys probably noticed the govuk-button
class used above makes it look like a button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely fine, yes! It doesn't matter what it looks like right now, only that the journey can be completed for test purposes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
<h1 class="govuk-heading-l">{{ pageHeading }}</h1> | ||
<a class="govuk-button" href="{{ MatchUtils.redirectToSpaceBookingsNew({placementRequestId: placementRequest.id, premisesName: premisesName, premisesId: premisesId, apType: apType, startDate: startDate, durationDays: durationDays }) }}"> | ||
Continue | ||
</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely fine, yes! It doesn't matter what it looks like right now, only that the journey can be completed for test purposes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Context
Occupancy View
ticketsChanges in this PR
/view-spaces
route when click on theView Spaces
link on theFind a space page
Confirm Booking
page to continue and finish the user journey) - please shout if I misunderstood and this is bad!Screenshots of UI changes