Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate to placeholder occupancy view #2213

Merged

Conversation

gregkhawkins
Copy link
Contributor

@gregkhawkins gregkhawkins commented Nov 22, 2024

Context

Changes in this PR

  • Navigate to new /view-spaces route when click on the View Spaces link on the Find a space page
  • Render a bare bones view (for this new route) with banner and header
  • The result of the above is that we hit this road block view (instead of navigating the Confirm Booking page to continue and finish the user journey) - please shout if I misunderstood and this is bad!
  • Changes to e2e tests so they do not fail when they hit the new road block
  • All e2e tests run and pass locally against AP tools

Screenshots of UI changes

occupancy_view

@gregkhawkins gregkhawkins force-pushed the feature/APS-1577__navigate_to_placeholder_occupancy_view branch 2 times, most recently from 6f32035 to df26491 Compare November 22, 2024 16:18
Copy link
Contributor

@froddd froddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of comments!

e2e/steps/match.ts Show resolved Hide resolved
@gregkhawkins gregkhawkins force-pushed the feature/APS-1577__navigate_to_placeholder_occupancy_view branch 4 times, most recently from 5d1ebd9 to c83839f Compare November 25, 2024 13:22
@gregkhawkins gregkhawkins force-pushed the feature/APS-1577__navigate_to_placeholder_occupancy_view branch from c83839f to 9fd323c Compare November 25, 2024 13:30
<h1 class="govuk-heading-l">{{ pageHeading }}</h1>
<a class="govuk-button" href="{{ MatchUtils.redirectToSpaceBookingsNew({placementRequestId: placementRequest.id, premisesName: premisesName, premisesId: premisesId, apType: apType, startDate: startDate, durationDays: durationDays }) }}">
Continue
</a>
Copy link
Contributor Author

@gregkhawkins gregkhawkins Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobmeredith @froddd in the long run (based on the Occupancy view designs) we will have "Continue" button within a "Book you placement" form that submits the date values entered into the form.
This is out of scope for this ticket, so for now I have just created an anchor link that redirects them back into the flow as per suggestion.
Hopefully an anchor link (not a button) will suffice for now? As you guys probably noticed the govuk-button class used above makes it look like a button

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely fine, yes! It doesn't matter what it looks like right now, only that the journey can be completed for test purposes :)

Copy link
Contributor

@froddd froddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

<h1 class="govuk-heading-l">{{ pageHeading }}</h1>
<a class="govuk-button" href="{{ MatchUtils.redirectToSpaceBookingsNew({placementRequestId: placementRequest.id, premisesName: premisesName, premisesId: premisesId, apType: apType, startDate: startDate, durationDays: durationDays }) }}">
Continue
</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely fine, yes! It doesn't matter what it looks like right now, only that the journey can be completed for test purposes :)

Copy link
Contributor

@bobmeredith bobmeredith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@gregkhawkins gregkhawkins merged commit dbe0497 into main Nov 26, 2024
7 checks passed
@gregkhawkins gregkhawkins deleted the feature/APS-1577__navigate_to_placeholder_occupancy_view branch November 26, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants