CDPT-1511 Intranet migration add microsoft login azure ad #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add oauth2 composer package - add env vars to example - add readme - how to make an azure entra app - add all error pages for nginx to statically serve
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Hey mate, this looks good! |
EarthlingDavey
changed the title
EarthlingDavey
changed the title
EarthlingDavey
changed the title
|
@wilson1000 is it ok with you if I spend an hour or 2 improving the code for this. I think it's so important that this is easy to read & maintain! If you've written some review comments already, would you mind submitting them please? Or, if you're mid-review, I can hold off. Cheers :) |
wilson1000
reviewed
Apr 17, 2024
There was a problem hiding this comment.
There are some conflicts but in general, this looks good.
I'd be really interested @EarthlingDavey to join a call with you just before this is launched on to development
EarthlingDavey
deleted the
CDPT-1511-intranet-migration-add-microsoft-login-azure-ad
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues on from work in #507
Adds support for login via Azure AD/Entra OAuth.
@wilson1000 I understand that we probably don't want to keep the Azure Oauth on dev for long, but can we add it in the short term for testing?