-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDPT-887 auth with nginx cache #612
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EarthlingDavey
commented
Jul 29, 2024
EarthlingDavey
commented
Jul 29, 2024
EarthlingDavey
commented
Jul 29, 2024
EarthlingDavey
commented
Jul 29, 2024
EarthlingDavey
commented
Jul 29, 2024
EarthlingDavey
commented
Jul 29, 2024
EarthlingDavey
commented
Jul 29, 2024
export default (function ($) { | ||
// Sent a request to the heartbeat endpoint, this will refresh the oauth token. | ||
setInterval(function(){ | ||
$.get( "/auth/heartbeat" ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If 401, modal - your session has ended, please login again for security purposes. Blur bg. Redirect in 5s.
The js can just reload the current page.
Change to 10s
EarthlingDavey
commented
Jul 29, 2024
EarthlingDavey
commented
Jul 29, 2024
EarthlingDavey
commented
Jul 29, 2024
EarthlingDavey
commented
Jul 29, 2024
EarthlingDavey
added a commit
that referenced
this pull request
Jul 29, 2024
EarthlingDavey
added a commit
that referenced
this pull request
Jul 29, 2024
* Updates from the review of #612 * Update auth-heartbeat.js * Update moj-auth.php * Update info.php * Fix comments and log messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
IPs
IPS_FORMATTED
env var.HTTP_X_IP_GROUP
is available to our application incase we want to show a deprecation warning. If we want to do this, we may need to add $geo to thefastcgi_cache_key
- or fetch the deprecation warning via an un-cached url like ajax.phpOauth
/auth/verify
endpoint that returns a 200 / 401 status, depending on a valid JWT. This endpoint doesn't load WordPress.Caching
Care has been taken to only serve cached results if the user is allowed.
Previously cached hits were served to non-auth'd users, this has been fixed.