CDPT-1896 Change the local and dev Entra apps to the Entra dev environment. #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilson1000
reviewed
Sep 30, 2024
.github/README.md
Outdated
| 6. Copy the `Application (client) ID` and `Directory (tenant) ID` values, | ||
| make them available as environment variables `OAUTH_CLIENT_ID`, `OAUTH_TENANT_ID`. | ||
| 7. Click on `Certificates & secrets` > `New client secret`. | ||
| 8. Fill in the form: | ||
| - Description: `Local-Intranet-v2` | ||
| - Description: `Staging-Intranet-v2` |
There was a problem hiding this comment.
Hey 😄
A quick Q... why are we using v2, do we know what does it means?
... maybe we can drop the v all together?
There was a problem hiding this comment.
Good point, it was to differentiate between Tactical Product's secrets, but I think it's unnecessary - I'll remove.
| OAUTH_CLIENT_ID: "1dac3cbf-91d2-4c0e-9c80-0bf3f8fabd75" | ||
| OAUTH_TENANT_ID: "c6874728-71e6-41fe-a9e1-2e8c36776ad8" | ||
| OAUTH_CLIENT_ID: "51266573-d4eb-41db-8ebe-a9548aa4f01e" | ||
| OAUTH_TENANT_ID: "0bb413d7-160d-4839-868a-f3d46537f6af" |
There was a problem hiding this comment.
These might (will) get flagged by the security squad at some point. Do they need to be hidden or are we good to roll with them?
There was a problem hiding this comment.
As discussed, I'll add a concise note as to why these are ok here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.