Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDPT-2186 Create a new container to push static assets as a k8s job. #742

Merged
merged 15 commits into from
Oct 25, 2024
Merged

CDPT-2186 Create a new container to push static assets as a k8s job. #742

merged 15 commits into from
Oct 25, 2024

Conversation

EarthlingDavey
Copy link
Contributor

@EarthlingDavey EarthlingDavey commented Oct 16, 2024 •
edited
Loading

This PR allows for theme, plugin and WordPress core assets to be synced to S3 and served via the CDN.

It can be broken down into parts/stages:

  1. A build step to create a docker image that contains all of the assets.
  2. A job is run at deploy time to run the docker image on Cloud Platform, this job syncs the assets to S3.
  3. The application checks that the files are available via S3, if they ar the asset urls are re-written from https://intranet... to https://cdn.intranet...

@EarthlingDavey EarthlingDavey marked this pull request as ready for review October 23, 2024 15:27
@EarthlingDavey EarthlingDavey marked this pull request as draft October 23, 2024 15:51
@EarthlingDavey EarthlingDavey marked this pull request as ready for review October 24, 2024 11:38
EmilyHazlehurst
EmilyHazlehurst approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@EmilyHazlehurst EmilyHazlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😄

@EarthlingDavey EarthlingDavey merged commit 890d741 into develop Oct 25, 2024
6 checks passed
@EarthlingDavey EarthlingDavey deleted the feature/cdpt-2186-push-assets-to-s3 branch October 25, 2024 10:28
@EarthlingDavey
Copy link
Contributor Author

Awesome, ty 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilyHazlehurst EmilyHazlehurst EmilyHazlehurst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EarthlingDavey @EmilyHazlehurst