CDPT-2223 Update logo for heartbeat and test version modals #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EarthlingDavey
changed the title
|
Do you have a representation of the layout change, if there is one? |
|
@EarthlingDavey comment above, cheers mate 👍 |
|
Thanks for reviewing, there is no change to layout. I found myself resizing the image to get the paragraph text to position correctly, underneath the image. Clearing float on the paragraph makes it always sit under the image. |
wilson1000
approved these changes
Oct 30, 2024
|
One more thing, can we get a base64 representation of this crest, instead of loading it through the URL? We can maybe save this in CSS and call a class with sizes to show it. |
|
Good spot! Are you ok with me creating a new svg for now and revisiting changing it to base64 post migration? |
wilson1000
approved these changes
Oct 30, 2024
EarthlingDavey
deleted the
cdpt-2223-update-logo-for-heartbeat-and-test-version-modals
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.