Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDPT-2228 Copying main theme to develop theme & various bug fixes. #757

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

EarthlingDavey
Copy link
Contributor

No description provided.

@@ -81,6 +81,7 @@
require_once 'inc/content-filter/search-query.php';
require_once 'inc/content-filter/search.php';
require_once 'inc/enqueue.php';
require_once 'inc/environment-notice.php';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this was intentionally removed, I've assumed it was a mistake and added it back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Morning @EarthlingDavey this was removed because Roots now declare the environment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ... thanks @wilson1000 !

Copy link
Contributor

@wilson1000 wilson1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mate, just one comment about the environment notice.

@@ -81,6 +81,7 @@
require_once 'inc/content-filter/search-query.php';
require_once 'inc/content-filter/search.php';
require_once 'inc/enqueue.php';
require_once 'inc/environment-notice.php';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Morning @EarthlingDavey this was removed because Roots now declare the environment.

@EarthlingDavey EarthlingDavey merged commit 1dd8630 into develop Oct 30, 2024
6 checks passed
@EarthlingDavey EarthlingDavey deleted the sync-changes-from-main branch October 30, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants