Make nginx readiness endpoint dependant on a working socket to fpm #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilson1000
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Hey @EarthlingDavey just a couple of comments. I'll leave the call to you.
| @@ -303,8 +308,18 @@ server { | |||
| # LOCATIONS - heath | |||
| ## | |||
|
|
|||
| location ~ ^/(liveness|readiness)$ { | |||
| location = /liveness { | |||
There was a problem hiding this comment.
Would this also benefit from skipping the cache?
if ($request_uri ~* "/liveness|/readiness") {
set $skip_cache 1;
}There was a problem hiding this comment.
Good shout, I'll make the change.
| @@ -140,6 +140,7 @@ public function serveMetrics(): void | |||
| { | |||
| header('Content-Type', 'text/plain'); | |||
| echo $this->getServiceMetrics(); | |||
| unset($this->guzzle_client); | |||
There was a problem hiding this comment.
We tested this, but it had no visual effect.
Do we still think it's needed, due to good-housekeeping, or should we consider removing?
There was a problem hiding this comment.
I don't think it can do any harm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.