Bug/CDPT-2258 Handle empty post and text domain. Add constructor to notify-for-wordpress #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilson1000
approved these changes
Nov 5, 2024
|
Good shout, I've made a note in the upstream PR that this find and replace must be removed if the upstream PR is merged and released. |
EarthlingDavey
deleted the
bug/cdpt-2258-handle-empty-post-and-text-domain
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug where the notify dashboard was firing a fatal php error.
This was because the plugin was not setting the text-domain correctly. This has been fixed in the upstream git repo and a patch fix in this PR.
In a defensive programming move,
coauthors_filter_texthas been changed so that text domain is an optional string.$post?->post_typeshould also fix the warningAttempt to read property "post_type" on null