CDPT-2227 Delete production CloudFront cookies when browsing dev, staging, & demo. #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code that:
Deletes production CloudFront cookies when browsing dev, staging, & demo.
This is important, as without this fix, 2 lots of CloudFront cookies are sent to e.g. cdn.staging.intranet.justive.gov.uk
This might seem a bit messy, but it's an unfortunate side-effect of:
One other solution would be to not have dev, staging, demo as sub-domains of the production site.
That's also not ideal as the staging url has already been shared with editors and has been used for a couple of rounds of QA.