CDPT-2264 Fix font assets, and debug logging typo.

[EarthlingDavey]

This PR includes 2 changes.

I've noticed that prior to the CPU spikes on FPM containers, in 5 cases there has been requests to font files that nginx could not find. This results in logs like:

2024/11/20 13:23:04 [error] 25#25: *138 open() "/var/www/html/public/app/themes/clarity/dist/globals/fonts/moji-clarity.woff" failed (2: No such file or directory), client: 172.20.201.206, server: localhost, request: "GET /app/themes/clarity/dist/globals/fonts/moji-clarity.woff?vklv4a HTTP/1.1", host: "intranet.justice.gov.uk", referrer: "https://intranet.justice.gov.uk/app/themes/clarity/dist/css/style.css"
2024/11/20 13:23:12 [error] 23#23: *57 open() "/var/www/html/public/app/themes/clarity/dist/globals/fonts/moji-clarity.woff" failed (2: No such file or directory), client: 172.20.173.150, server: localhost, request: "GET /app/themes/clarity/dist/globals/fonts/moji-clarity.woff?vklv4a HTTP/1.1", host: "intranet.justice.gov.uk", referrer: "https://intranet.justice.gov.uk/app/themes/clarity/dist/css/style.css"
2024/11/20 13:23:15 [error] 22#22: *17 open() "/var/www/html/public/app/themes/clarity/dist/globals/fonts/moji-clarity.ttf" failed (2: No such file or directory), client: 172.20.173.150, server: localhost, request: "GET /app/themes/clarity/dist/globals/fonts/moji-clarity.ttf?vklv4a HTTP/1.1", host: "intranet.justice.gov.uk", referrer: "https://intranet.justice.gov.uk/app/themes/clarity/dist/css/style.css"
2024/11/20 13:23:58 [error] 23#23: *962 open() "/var/www/html/public/app/themes/clarity/dist/globals/fonts/moji-clarity.woff" failed (2: No such file or directory), client: 172.20.133.161, server: localhost, request: "GET /app/themes/clarity/dist/globals/fonts/moji-clarity.woff?vklv4a HTTP/1.1", host: "intranet.justice.gov.uk", referrer: "https://intranet.justice.gov.uk/app/themes/clarity/dist/css/style.css"

The font files in question are not at /dist/globals/fonts/moji-clarity.woff but /dist/fonts/moji-clarity.woff without globals in the name.

I noticed that the path is correct in https://intranet.justice.gov.uk/app/themes/clarity/dist/css/globals.css but incorrct in https://intranet.justice.gov.uk/app/themes/clarity/dist/css/style.css

I also saw that globals.css and style.css are both loaded on all frontend pages.

The fix is to move the @font-family css statement to fonts.styl, so that it is included only in globals.css and with the correct path.

---

The 2nd fix is to debug logging, there was an error because I typed document_serve instead of serve_document. The former is a filter and the latter is an action. This has been addressed and the add_action parameters have also been tidied up.

[wilson1000]

Give it whirl 😄