Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDPT-2264 Improve nginx's file serving. #790

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

EarthlingDavey
Copy link
Contributor

Previously a missing file caused an error. Now it's a 404 without an error.

Before:

[error] 30#30: *22939 open() "/var/www/html/public/app/themes/clarity/dist/globals/fonts/moji-clarity.ttf" failed (2: No such file or directory), client: 172.20.163.241, server: localhost, request: "GET /app/themes/clarity/dist/globals/fonts/moji-clarity.ttf?vklv4a HTTP/1.1", host: "intranet.justice.gov.uk", referrer: "https://intranet.justice.gov.uk/app/themes/clarity/dist/css/style.css?id=403678736ef4bf78b9131a99ad902082"

After:

172.21.0.8 - - [20/Nov/2024:16:19:12 +0000] "GET /app/themes/clarity/dist/globals/fonts/moji-clarity.ttf HTTP/1.1" 404 1375 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/130.0.0.0 Safari/537.36" "192.168.65.1"

Previously a missing file caused an error. Now it's a 404 without an error.
@EarthlingDavey EarthlingDavey merged commit c935085 into main Nov 21, 2024
6 checks passed
@EarthlingDavey EarthlingDavey deleted the cdpt-2264-improve-nginx-file-serving branch November 21, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants