Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDPT-1995: TypeError: r(...) is not a function #276

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

EmilyHazlehurst
Copy link
Contributor

  • remove nselect.js script and all reference
  • copy css for the select box but use default browser styles for the dropdown

- remove nselect.js script and all reference
- copy css for the select box but use default browser styles for the dropdown
Copy link
Contributor

@wilson1000 wilson1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment on SASS usage

public/app/themes/justice/src/css/global.css Outdated Show resolved Hide resolved
@EmilyHazlehurst
Copy link
Contributor Author

A comment on SASS usage

Thanks @wilson1000, I've moved the form styling into form.scss for consistency.

Copy link
Contributor

@wilson1000 wilson1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@EmilyHazlehurst EmilyHazlehurst merged commit c110974 into main Oct 14, 2024
6 checks passed
@EmilyHazlehurst EmilyHazlehurst deleted the feature/cdpt-1995-typeerror-fix branch October 14, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants