Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDLS-54b Cloud9 make users settable without pr #1473

Merged
merged 4 commits into from
Nov 28, 2023
Merged

DDLS-54b Cloud9 make users settable without pr #1473

merged 4 commits into from
Nov 28, 2023

Conversation

jamesrwarren
Copy link
Contributor

@jamesrwarren jamesrwarren commented Nov 28, 2023

Purpose

Allow us to dynamically update the list of users and don't keep the users in our repo code

Fixes DDLS-54

Approach

Use the contents of a secret in json format to provide the correct arguments

Learning

NA

Checklist

  • I have performed a self-review of my own code
  • I have updated documentation (Confluence/ADR/tech debt doc) where relevant
  • I have added tests to prove my work
  • The product team have approved these changes
  • I have checked my work for potential security issues and refered to the OWASP top 10

Frontend

  • I have run an in-browser accessibility test (e.g. WAVE, Lighthouse)
  • There are no deprecated CSS classes noted in the profiler
  • Translations are used and the profiler doesn't identify any missing
  • Any links or buttons added are screen reader friendly and contextually complete
  • If adding GA events, I have updated or checked the existing category or label values

@jamesrwarren jamesrwarren changed the title Ddls 54b DDLS-54b Cloud9 make users settable without pr Nov 28, 2023
@jamesrwarren jamesrwarren marked this pull request as ready for review November 28, 2023 12:53
@jamesrwarren jamesrwarren requested a review from a team as a code owner November 28, 2023 12:53
@jamesrwarren jamesrwarren merged commit 761ede0 into main Nov 28, 2023
@jamesrwarren jamesrwarren deleted the DDLS-54b branch November 28, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants