Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDLS-7A: Extension of DDLS-7 branch (Money In) #1476

Merged
merged 1 commit into from
Nov 30, 2023
Merged

DDLS-7A: Extension of DDLS-7 branch (Money In) #1476

merged 1 commit into from
Nov 30, 2023

Conversation

MiaGordon91
Copy link
Contributor

Purpose

Had to drop dump function as it accidentally got released as part of DDLS-7 which has triggered alarms in prod

Fixes DDLS-7A

Approach

Explain how your code addresses the purpose of the change

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about DigiDeps

Checklist

  • I have performed a self-review of my own code
  • I have updated documentation (Confluence/ADR/tech debt doc) where relevant
  • I have added tests to prove my work
  • The product team have approved these changes
  • I have checked my work for potential security issues and refered to the OWASP top 10

Frontend

  • I have run an in-browser accessibility test (e.g. WAVE, Lighthouse)
  • There are no deprecated CSS classes noted in the profiler
  • Translations are used and the profiler doesn't identify any missing
  • Any links or buttons added are screen reader friendly and contextually complete
  • If adding GA events, I have updated or checked the existing category or label values

@MiaGordon91 MiaGordon91 requested a review from a team as a code owner November 30, 2023 09:35
@MiaGordon91 MiaGordon91 merged commit 3f2b17e into main Nov 30, 2023
36 checks passed
@MiaGordon91 MiaGordon91 deleted the DDLS-7A branch November 30, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants